From ea8381411b2db679391e25733b3d48947e55f41b Mon Sep 17 00:00:00 2001 From: Adam Niedzielski Date: Fri, 2 Jun 2017 17:17:24 +0200 Subject: Use sum instead of map + inject --- .../conversational_development_index/idea_to_production_step.rb | 4 ++-- app/presenters/conversational_development_index/metric_presenter.rb | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) (limited to 'app') diff --git a/app/models/conversational_development_index/idea_to_production_step.rb b/app/models/conversational_development_index/idea_to_production_step.rb index f53227f8a27..6e1753c9f30 100644 --- a/app/models/conversational_development_index/idea_to_production_step.rb +++ b/app/models/conversational_development_index/idea_to_production_step.rb @@ -9,9 +9,9 @@ module ConversationalDevelopmentIndex end def percentage_score - sum = features.map do |feature| + sum = features.sum do |feature| metric.percentage_score(feature) - end.inject(:+) + end sum / features.size.to_f end diff --git a/app/presenters/conversational_development_index/metric_presenter.rb b/app/presenters/conversational_development_index/metric_presenter.rb index 220014a955a..bb65ba2646b 100644 --- a/app/presenters/conversational_development_index/metric_presenter.rb +++ b/app/presenters/conversational_development_index/metric_presenter.rb @@ -138,7 +138,7 @@ module ConversationalDevelopmentIndex end def average_percentage_score - cards.map(&:percentage_score).inject(:+) / cards.size.to_f + cards.sum(&:percentage_score) / cards.size.to_f end end end -- cgit v1.2.3