From 3d9c28af9331feb279053113677af2633e4b8e91 Mon Sep 17 00:00:00 2001 From: Stan Hu Date: Wed, 31 Jul 2019 06:49:56 -0700 Subject: Fix first-time contributor notes not rendering https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/31117 enabled the HashInefficientHash Rubocop rule that was fooled by the special implementation of `SpecialRole`. We fix this by introducing a `value?` method and adding unit tests. Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/65383 --- changelogs/unreleased/sh-fix-special-role-error-500.yml | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 changelogs/unreleased/sh-fix-special-role-error-500.yml (limited to 'changelogs') diff --git a/changelogs/unreleased/sh-fix-special-role-error-500.yml b/changelogs/unreleased/sh-fix-special-role-error-500.yml new file mode 100644 index 00000000000..9aed0710da3 --- /dev/null +++ b/changelogs/unreleased/sh-fix-special-role-error-500.yml @@ -0,0 +1,5 @@ +--- +title: Fix first-time contributor notes not rendering +merge_request: 31340 +author: +type: fixed -- cgit v1.2.3