From b1849ee2e66b6355776397717a33dc7ada772332 Mon Sep 17 00:00:00 2001 From: Douwe Maan Date: Tue, 28 Nov 2017 17:16:50 +0100 Subject: Use a dedicated queue for each worker --- config/initializers/sidekiq.rb | 18 ++---------------- config/sidekiq_queues.yml | 8 +++++--- 2 files changed, 7 insertions(+), 19 deletions(-) (limited to 'config') diff --git a/config/initializers/sidekiq.rb b/config/initializers/sidekiq.rb index ba4481ae602..0f164e628f9 100644 --- a/config/initializers/sidekiq.rb +++ b/config/initializers/sidekiq.rb @@ -42,6 +42,8 @@ Sidekiq.configure_server do |config| Gitlab::SidekiqThrottler.execute! + Gitlab::SidekiqVersioning.install! + config = Gitlab::Database.config || Rails.application.config.database_configuration[Rails.env] config['pool'] = Sidekiq.options[:concurrency] @@ -60,19 +62,3 @@ Sidekiq.configure_client do |config| chain.add Gitlab::SidekiqStatus::ClientMiddleware end end - -# The Sidekiq client API always adds the queue to the Sidekiq queue -# list, but mail_room and gitlab-shell do not. This is only necessary -# for monitoring. -begin - queues = Gitlab::SidekiqConfig.worker_queues - - Sidekiq.redis do |conn| - conn.pipelined do - queues.each do |queue| - conn.sadd('queues', queue) - end - end - end -rescue Redis::BaseError, SocketError, Errno::ENOENT, Errno::EADDRNOTAVAIL, Errno::EAFNOSUPPORT, Errno::ECONNRESET, Errno::ECONNREFUSED -end diff --git a/config/sidekiq_queues.yml b/config/sidekiq_queues.yml index bc7c431731a..5c8233d796f 100644 --- a/config/sidekiq_queues.yml +++ b/config/sidekiq_queues.yml @@ -25,8 +25,8 @@ - [new_note, 2] - [new_issue, 2] - [new_merge_request, 2] - - [build, 2] - - [pipeline, 2] + - [build, 2] # Replaced by pipeline + - [pipeline, 2] # Replaced by pipeline_* - [pipeline_processing, 5] - [pipeline_creation, 4] - [pipeline_default, 3] @@ -38,11 +38,13 @@ - [mailers, 2] - [invalid_gpg_signature_update, 2] - [create_gpg_signature, 2] + - [rebase, 2] - [upload_checksum, 1] - [repository_fork, 1] - [repository_import, 1] - [github_importer, 1] - - [github_importer_advance_stage, 1] + - [github_importer_advance_stage, 1] # Replaced by github_import_advance_stage + - [github_import_advance_stage, 1] - [project_service, 1] - [delete_user, 1] - [delete_merged_branches, 1] -- cgit v1.2.3 From 4a6ba82b28b0219a13dcb8732361193e9c9b3890 Mon Sep 17 00:00:00 2001 From: Douwe Maan Date: Wed, 13 Dec 2017 16:14:49 +0100 Subject: Remove unused queues --- config/sidekiq_queues.yml | 3 --- 1 file changed, 3 deletions(-) (limited to 'config') diff --git a/config/sidekiq_queues.yml b/config/sidekiq_queues.yml index 5c8233d796f..31a38f2b508 100644 --- a/config/sidekiq_queues.yml +++ b/config/sidekiq_queues.yml @@ -25,8 +25,6 @@ - [new_note, 2] - [new_issue, 2] - [new_merge_request, 2] - - [build, 2] # Replaced by pipeline - - [pipeline, 2] # Replaced by pipeline_* - [pipeline_processing, 5] - [pipeline_creation, 4] - [pipeline_default, 3] @@ -43,7 +41,6 @@ - [repository_fork, 1] - [repository_import, 1] - [github_importer, 1] - - [github_importer_advance_stage, 1] # Replaced by github_import_advance_stage - [github_import_advance_stage, 1] - [project_service, 1] - [delete_user, 1] -- cgit v1.2.3