From cf777261888cb4baccd03b3d1ca491cb5b1a65f3 Mon Sep 17 00:00:00 2001 From: Lin Jen-Shin Date: Tue, 10 Jul 2018 20:05:57 +0800 Subject: Make sure we're matching the same way. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Ruby's regular expression is unicode aware, therefore 'å' also matches against /\p{alnum}/. If we want only ASCII-7bit, use [a-zA-Z0-9]+ so they always match the same thing --- db/fixtures/development/19_environments.rb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'db/fixtures') diff --git a/db/fixtures/development/19_environments.rb b/db/fixtures/development/19_environments.rb index 00a14f458d1..65089f6ba4e 100644 --- a/db/fixtures/development/19_environments.rb +++ b/db/fixtures/development/19_environments.rb @@ -30,14 +30,14 @@ class Gitlab::Seeder::Environments def create_merge_request_review_deployments! @project .merge_requests - .select { |mr| mr.source_branch.match(/\p{Alnum}+/) } + .select { |mr| mr.source_branch.match(/[^a-zA-Z0-9]+/) } .sample(4) .each do |merge_request| next unless merge_request.diff_head_sha create_deployment!( merge_request.source_project, - "review/#{merge_request.source_branch.gsub(/[^a-zA-Z0-9]/, '')}", + "review/#{merge_request.source_branch.gsub(/[^a-zA-Z0-9]+/, '')}", merge_request.source_branch, merge_request.diff_head_sha ) -- cgit v1.2.3