From ff3486a92bfcf00b85d45c9224c27cc5fa9c49e2 Mon Sep 17 00:00:00 2001 From: Thomas Nilsson Date: Mon, 20 May 2019 12:49:23 +0000 Subject: Allow masking if 8 or more characters in base64 This should allow for private ssh-keys to remain private. Solves https://gitlab.com/gitlab-org/gitlab-ce/issues/60790. --- doc/ci/variables/README.md | 1 + 1 file changed, 1 insertion(+) (limited to 'doc/ci') diff --git a/doc/ci/variables/README.md b/doc/ci/variables/README.md index fe64f5ab2e0..b17ad625c9e 100644 --- a/doc/ci/variables/README.md +++ b/doc/ci/variables/README.md @@ -95,6 +95,7 @@ though it must match certain requirements to do so: - The value must contain only letters, numbers, or underscores. - The value must be at least 8 characters long. - The value must not use variables. +- The value must only consist of characters from the Base64 alphabet, defined in [RFC4648](https://tools.ietf.org/html/rfc4648). If the value does not meet the requirements above, then the CI variable will fail to save. In order to save, either alter the value to meet the masking requirements -- cgit v1.2.3 From 432d24ac9a84700ed5d1d798f705c2a1e40903dd Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Matija=20=C4=8Cupi=C4=87?= Date: Tue, 4 Jun 2019 17:36:40 +0200 Subject: Expose javascript regex --- doc/ci/variables/README.md | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) (limited to 'doc/ci') diff --git a/doc/ci/variables/README.md b/doc/ci/variables/README.md index b17ad625c9e..df455857dee 100644 --- a/doc/ci/variables/README.md +++ b/doc/ci/variables/README.md @@ -92,10 +92,9 @@ This means that the value of the variable will be hidden in job logs, though it must match certain requirements to do so: - The value must be in a single line. -- The value must contain only letters, numbers, or underscores. +- The value must only consist of characters from the Base64 alphabet, defined in [RFC4648](https://tools.ietf.org/html/rfc4648). - The value must be at least 8 characters long. - The value must not use variables. -- The value must only consist of characters from the Base64 alphabet, defined in [RFC4648](https://tools.ietf.org/html/rfc4648). If the value does not meet the requirements above, then the CI variable will fail to save. In order to save, either alter the value to meet the masking requirements -- cgit v1.2.3