From 45482d5a2704da7fabe4ccf07f85d9be6e0a791a Mon Sep 17 00:00:00 2001 From: GitLab Bot Date: Fri, 27 Sep 2019 12:06:07 +0000 Subject: Add latest changes from gitlab-org/gitlab@master --- doc/development/gotchas.md | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) (limited to 'doc/development/gotchas.md') diff --git a/doc/development/gotchas.md b/doc/development/gotchas.md index 1a9ec7eb3e1..32efef2a9b3 100644 --- a/doc/development/gotchas.md +++ b/doc/development/gotchas.md @@ -144,13 +144,11 @@ refresh_service.execute(oldrev, newrev, ref) ## Do not `rescue Exception` -See ["Why is it bad style to `rescue Exception => e` in Ruby?"][Exception]. +See ["Why is it bad style to `rescue Exception => e` in Ruby?"](https://stackoverflow.com/questions/10048173/why-is-it-bad-style-to-rescue-exception-e-in-ruby). _**Note:** This rule is [enforced automatically by Rubocop](https://gitlab.com/gitlab-org/gitlab/blob/8-4-stable/.rubocop.yml#L911-914)._ -[Exception]: http://stackoverflow.com/q/10048173/223897 - ## Do not use inline JavaScript in views Using the inline `:javascript` Haml filters comes with a @@ -161,4 +159,4 @@ in an initializer._ ### Further reading -- Stack Overflow: [Why you should not write inline JavaScript](http://programmers.stackexchange.com/questions/86589/why-should-i-avoid-inline-scripting) +- Stack Overflow: [Why you should not write inline JavaScript](https://softwareengineering.stackexchange.com/questions/86589/why-should-i-avoid-inline-scripting) -- cgit v1.2.3