From 9f46488805e86b1bc341ea1620b866016c2ce5ed Mon Sep 17 00:00:00 2001 From: GitLab Bot Date: Wed, 20 May 2020 14:34:42 +0000 Subject: Add latest changes from gitlab-org/gitlab@13-0-stable-ee --- .../new_fe_guide/development/accessibility.md | 23 +++++++--------------- .../new_fe_guide/modules/dirty_submit.md | 2 +- 2 files changed, 8 insertions(+), 17 deletions(-) (limited to 'doc/development/new_fe_guide') diff --git a/doc/development/new_fe_guide/development/accessibility.md b/doc/development/new_fe_guide/development/accessibility.md index 8d9f7ca5069..aa76a9fec07 100644 --- a/doc/development/new_fe_guide/development/accessibility.md +++ b/doc/development/new_fe_guide/development/accessibility.md @@ -6,13 +6,13 @@ Using semantic HTML plays a key role when it comes to accessibility. WAI-ARIA (the Accessible Rich Internet Applications specification) defines a way to make Web content and Web applications more accessible to people with disabilities. -> Note: It is [recommended][using-aria] to use semantic elements as the primary method to achieve accessibility rather than adding aria attributes. Adding aria attributes should be seen as a secondary method for creating accessible elements. +> Note: It is [recommended](https://www.w3.org/TR/using-aria/#notes2) to use semantic elements as the primary method to achieve accessibility rather than adding aria attributes. Adding aria attributes should be seen as a secondary method for creating accessible elements. ### Role The `role` attribute describes the role the element plays in the context of the document. -Check the list of WAI-ARIA roles [here][roles] +Check the list of WAI-ARIA roles [here](https://www.w3.org/TR/wai-aria-1.1/#landmark_roles) ## Icons @@ -36,20 +36,11 @@ In forms we should use the `for` attribute in the label statement: ## Testing -1. On MacOS you can use [VoiceOver][voice-over] by pressing `cmd+F5`. -1. On Windows you can use [Narrator][narrator] by pressing Windows logo key + Ctrl + Enter. +1. On MacOS you can use [VoiceOver](https://www.apple.com/accessibility/mac/vision/) by pressing `cmd+F5`. +1. On Windows you can use [Narrator](https://www.microsoft.com/en-us/accessibility/windows) by pressing Windows logo key + Ctrl + Enter. ## Online resources -- [Chrome Accessibility Developer Tools][dev-tools] for testing accessibility -- [Audit Rules Page][audit-rules] for best practices -- [Lighthouse Accessibility Score][lighthouse] for accessibility audits - -[using-aria]: https://www.w3.org/TR/using-aria/#notes2 -[dev-tools]: https://github.com/GoogleChrome/accessibility-developer-tools -[audit-rules]: https://github.com/GoogleChrome/accessibility-developer-tools/wiki/Audit-Rules -[aria-w3c]: https://www.w3.org/TR/wai-aria-1.1/ -[roles]: https://www.w3.org/TR/wai-aria-1.1/#landmark_roles -[voice-over]: https://www.apple.com/accessibility/mac/vision/ -[narrator]: https://www.microsoft.com/en-us/accessibility/windows -[lighthouse]: https://developers.google.com/web/tools/lighthouse/scoring#a11y +- [Chrome Accessibility Developer Tools](https://github.com/GoogleChrome/accessibility-developer-tools) for testing accessibility +- [Audit Rules Page](https://github.com/GoogleChrome/accessibility-developer-tools/wiki/Audit-Rules) for best practices +- [Lighthouse Accessibility Score](https://developers.google.com/web/tools/lighthouse/scoring#a11y) for accessibility audits diff --git a/doc/development/new_fe_guide/modules/dirty_submit.md b/doc/development/new_fe_guide/modules/dirty_submit.md index 30cf8017820..dd336ad3a90 100644 --- a/doc/development/new_fe_guide/modules/dirty_submit.md +++ b/doc/development/new_fe_guide/modules/dirty_submit.md @@ -13,7 +13,7 @@ within the GitLab project. ## Usage -```js +```javascript import dirtySubmitFactory from './dirty_submit/dirty_submit_form'; new DirtySubmitForm(document.querySelector('form')); -- cgit v1.2.3