From efbc7a39da14634105596a964e530530f7178058 Mon Sep 17 00:00:00 2001 From: Patrick Bajao Date: Fri, 23 Aug 2019 15:50:41 +0800 Subject: Doc: Add info about update/delete restriction --- doc/api/merge_request_approvals.md | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) (limited to 'doc') diff --git a/doc/api/merge_request_approvals.md b/doc/api/merge_request_approvals.md index e1aca97f3a7..e60560d5625 100644 --- a/doc/api/merge_request_approvals.md +++ b/doc/api/merge_request_approvals.md @@ -704,7 +704,7 @@ POST /projects/:id/merge_requests/:merge_request_iid/approval_rules | `users` | integer | no | The ids of users as approvers | | `groups` | integer | no | The ids of groups as approvers | -**Important:** WHen `approval_project_rule_id` is set, the `name`, `users` and +**Important:** When `approval_project_rule_id` is set, the `name`, `users` and `groups` of project-level rule will be copied. The `approvals_required` specified will be used. @@ -777,6 +777,9 @@ PUT /projects/:id/merge_request/:merge_request_iid/approval_rules/:approval_rule **Important:** Approvers and groups not in the `users`/`groups` param will be **removed** +**Important:** Updating a `report_approver` or `code_owner` rule is not allowed. +These are system generated rules. + **Parameters:** | Attribute | Type | Required | Description | @@ -856,6 +859,9 @@ You can delete merge request approval rules using the following endpoint: DELETE /projects/:id/merge_requests/:merge_request_iid/approval_rules/:approval_rule_id ``` +**Important:** Deleting a `report_approver` or `code_owner` rule is not allowed. +These are system generated rules. + **Parameters:** | Attribute | Type | Required | Description | -- cgit v1.2.3