From 29f2600ab6b04d95c7ef4fbfea7c4c9ecf638e97 Mon Sep 17 00:00:00 2001 From: Grzegorz Bizon Date: Mon, 8 Feb 2016 12:42:35 +0100 Subject: Improve build badge tests, add another test case --- features/steps/project/builds/badge.rb | 13 +++++++++---- features/steps/shared/builds.rb | 4 ++++ 2 files changed, 13 insertions(+), 4 deletions(-) (limited to 'features/steps') diff --git a/features/steps/project/builds/badge.rb b/features/steps/project/builds/badge.rb index 3cf1e2cab5e..0ceb4ddcd25 100644 --- a/features/steps/project/builds/badge.rb +++ b/features/steps/project/builds/badge.rb @@ -8,18 +8,23 @@ class Spinach::Features::ProjectBuildsBadge < Spinach::FeatureSteps end step 'I should see a build success badge' do - expect(svg.at('text:contains("success")')).to be_truthy + expect_badge('success') end step 'I should see a build failed badge' do - expect(svg.at('text:contains("failed")')).to be_truthy + expect_badge('failed') end - step 'build badge is a svg image' do - expect(page.response_headers).to include('Content-Type' => 'image/svg+xml') + step 'I should see a build running badge' do + expect_badge('running') end def svg Nokogiri::HTML.parse(page.body) end + + def expect_badge(status) + expect(page.response_headers).to include('Content-Type' => 'image/svg+xml') + expect(svg.at(%Q{text:contains("#{status}")})).to be_truthy + end end diff --git a/features/steps/shared/builds.rb b/features/steps/shared/builds.rb index 055ebe1c815..7e1d9bb4056 100644 --- a/features/steps/shared/builds.rb +++ b/features/steps/shared/builds.rb @@ -18,6 +18,10 @@ module SharedBuilds @build.update_column(:status, 'failed') end + step 'project has an another build that is running' do + create(:ci_build, commit: @ci_commit, name: 'second build', status: 'running') + end + step 'I visit recent build details page' do visit namespace_project_build_path(@project.namespace, @project, @build) end -- cgit v1.2.3