From 48ebfaa49146b8f6fcb24b063f22d553b2f20395 Mon Sep 17 00:00:00 2001
From: Kamil Trzcinski <ayufan@ayufan.eu>
Date: Fri, 16 Dec 2016 11:31:26 +0100
Subject: Improve Mattermost Session specs

---
 lib/mattermost/session.rb | 23 ++++++++++++-----------
 1 file changed, 12 insertions(+), 11 deletions(-)

(limited to 'lib/mattermost')

diff --git a/lib/mattermost/session.rb b/lib/mattermost/session.rb
index f4629585da7..7d0290be5a1 100644
--- a/lib/mattermost/session.rb
+++ b/lib/mattermost/session.rb
@@ -17,7 +17,7 @@ module Mattermost
     include Doorkeeper::Helpers::Controller
     include HTTParty
 
-    attr_accessor :current_resource_owner
+    attr_accessor :current_resource_owner, :token
 
     def initialize(uri, current_user)
       # Sets the base uri for HTTParty, so we can use paths
@@ -64,9 +64,9 @@ module Mattermost
       return unless oauth_uri
       return unless token_uri
 
-      self.class.headers("Cookie" => "MMAUTHTOKEN=#{request_token}")
-
-      request_token
+      self.token = request_token
+      self.class.headers("Cookie" => "MMAUTHTOKEN=#{self.token}")
+      self.token
     end
 
     def destroy
@@ -84,16 +84,17 @@ module Mattermost
     end
 
     def token_uri
-      @token_uri ||= if @oauth_uri
-                       authorization.authorize.redirect_uri if pre_auth.authorizable?
-                     end
+      @token_uri ||=
+        if @oauth_uri
+          authorization.authorize.redirect_uri if pre_auth.authorizable?
+        end
     end
 
     def request_token
-      @request_token ||= begin
-                           response = get(@token_uri, follow_redirects: false)
-                           response.headers['token'] if 200 <= response.code && response.code < 400
-                         end
+      response = get(@token_uri, follow_redirects: false)
+      if 200 <= response.code && response.code < 400
+        response.headers['token']
+      end
     end
 
     def get(path, options = {})
-- 
cgit v1.2.3