From 6c5f3e7b4eaf92ccdd8f2e5b6204683441e207ec Mon Sep 17 00:00:00 2001 From: GitLab Bot Date: Tue, 9 Feb 2021 15:09:39 +0000 Subject: Add latest changes from gitlab-org/gitlab@master --- qa/qa/page/main/menu.rb | 6 +++--- qa/qa/resource/personal_access_token.rb | 2 +- qa/qa/resource/ssh_key.rb | 2 +- .../features/browser_ui/1_manage/login/2fa_ssh_recovery_spec.rb | 2 +- qa/qa/specs/features/browser_ui/1_manage/login/register_spec.rb | 2 +- .../features/browser_ui/3_create/repository/ssh_key_support_spec.rb | 2 +- qa/qa/tools/revoke_all_personal_access_tokens.rb | 2 +- 7 files changed, 9 insertions(+), 9 deletions(-) (limited to 'qa') diff --git a/qa/qa/page/main/menu.rb b/qa/qa/page/main/menu.rb index 627809dacf2..f0df901a8f0 100644 --- a/qa/qa/page/main/menu.rb +++ b/qa/qa/page/main/menu.rb @@ -6,7 +6,7 @@ module QA class Menu < Page::Base view 'app/views/layouts/header/_current_user_dropdown.html.haml' do element :sign_out_link - element :settings_link + element :edit_profile_link end view 'app/views/layouts/header/_default.html.haml' do @@ -115,10 +115,10 @@ module QA sign_out if signed_in? end - def click_settings_link + def click_edit_profile_link retry_until(reload: false) do within_user_menu do - click_link 'Settings' + click_element(:edit_profile_link) end has_text?('User Settings') diff --git a/qa/qa/resource/personal_access_token.rb b/qa/qa/resource/personal_access_token.rb index 488138326df..6b2301ba916 100644 --- a/qa/qa/resource/personal_access_token.rb +++ b/qa/qa/resource/personal_access_token.rb @@ -15,7 +15,7 @@ module QA end def fabricate! - Page::Main::Menu.perform(&:click_settings_link) + Page::Main::Menu.perform(&:click_edit_profile_link) Page::Profile::Menu.perform(&:click_access_tokens) Page::Profile::PersonalAccessTokens.perform do |token_page| diff --git a/qa/qa/resource/ssh_key.rb b/qa/qa/resource/ssh_key.rb index fcd0a479fec..52526275cb0 100644 --- a/qa/qa/resource/ssh_key.rb +++ b/qa/qa/resource/ssh_key.rb @@ -22,7 +22,7 @@ module QA end def fabricate! - Page::Main::Menu.perform(&:click_settings_link) + Page::Main::Menu.perform(&:click_edit_profile_link) Page::Profile::Menu.perform(&:click_ssh_keys) Page::Profile::SSHKeys.perform do |profile_page| diff --git a/qa/qa/specs/features/browser_ui/1_manage/login/2fa_ssh_recovery_spec.rb b/qa/qa/specs/features/browser_ui/1_manage/login/2fa_ssh_recovery_spec.rb index f6d2492c011..3702f95158c 100644 --- a/qa/qa/specs/features/browser_ui/1_manage/login/2fa_ssh_recovery_spec.rb +++ b/qa/qa/specs/features/browser_ui/1_manage/login/2fa_ssh_recovery_spec.rb @@ -48,7 +48,7 @@ module QA def enable_2fa_for_user(user) Flow::Login.while_signed_in(as: user) do - Page::Main::Menu.perform(&:click_settings_link) + Page::Main::Menu.perform(&:click_edit_profile_link) Page::Profile::Menu.perform(&:click_account) Page::Profile::Accounts::Show.perform(&:click_enable_2fa_button) diff --git a/qa/qa/specs/features/browser_ui/1_manage/login/register_spec.rb b/qa/qa/specs/features/browser_ui/1_manage/login/register_spec.rb index d9b246fc458..ffc2290b644 100644 --- a/qa/qa/specs/features/browser_ui/1_manage/login/register_spec.rb +++ b/qa/qa/specs/features/browser_ui/1_manage/login/register_spec.rb @@ -58,7 +58,7 @@ module QA # this is the only test that exercise this UI. # Other tests should use the API for this purpose. Flow::Login.sign_in(as: user) - Page::Main::Menu.perform(&:click_settings_link) + Page::Main::Menu.perform(&:click_edit_profile_link) Page::Profile::Menu.perform(&:click_account) Page::Profile::Accounts::Show.perform do |show| show.delete_account(user.password) diff --git a/qa/qa/specs/features/browser_ui/3_create/repository/ssh_key_support_spec.rb b/qa/qa/specs/features/browser_ui/3_create/repository/ssh_key_support_spec.rb index 2001069c2a4..158bd19704e 100644 --- a/qa/qa/specs/features/browser_ui/3_create/repository/ssh_key_support_spec.rb +++ b/qa/qa/specs/features/browser_ui/3_create/repository/ssh_key_support_spec.rb @@ -21,7 +21,7 @@ module QA # Note this context ensures that the example it contains is executed after the example above. Be aware of the order of execution if you add new examples in either context. context 'after adding an ssh key' do it 'can delete an ssh key', testcase: 'https://gitlab.com/gitlab-org/quality/testcases/-/issues/930' do - Page::Main::Menu.perform(&:click_settings_link) + Page::Main::Menu.perform(&:click_edit_profile_link) Page::Profile::Menu.perform(&:click_ssh_keys) Page::Profile::SSHKeys.perform do |ssh_keys| ssh_keys.remove_key(key.title) diff --git a/qa/qa/tools/revoke_all_personal_access_tokens.rb b/qa/qa/tools/revoke_all_personal_access_tokens.rb index e33d522bece..0aaf1ed6f7f 100644 --- a/qa/qa/tools/revoke_all_personal_access_tokens.rb +++ b/qa/qa/tools/revoke_all_personal_access_tokens.rb @@ -27,7 +27,7 @@ module QA Runtime::Browser.visit(ENV['GITLAB_ADDRESS'], Page::Main::Login) Page::Main::Login.perform(&:sign_in_using_credentials) - Page::Main::Menu.perform(&:click_settings_link) + Page::Main::Menu.perform(&:click_edit_profile_link) Page::Profile::Menu.perform(&:click_access_tokens) token_name = 'api-test-token' -- cgit v1.2.3