From 96ce2da74ee36e88f20cbd7ceaff2ab49f0bb223 Mon Sep 17 00:00:00 2001 From: Yorick Peterse Date: Thu, 16 Aug 2018 14:28:25 +0200 Subject: Blacklist the use of "destroy_all" This method usually has really bad performance implications, as it loads rows into memory and deletes them one by one. --- rubocop/cop/destroy_all.rb | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) create mode 100644 rubocop/cop/destroy_all.rb (limited to 'rubocop/cop') diff --git a/rubocop/cop/destroy_all.rb b/rubocop/cop/destroy_all.rb new file mode 100644 index 00000000000..38b6cb40f91 --- /dev/null +++ b/rubocop/cop/destroy_all.rb @@ -0,0 +1,22 @@ +# frozen_string_literal: true + +module RuboCop + module Cop + # Cop that blacklists the use of `destroy_all`. + class DestroyAll < RuboCop::Cop::Cop + MSG = 'Use `delete_all` instead of `destroy_all`. ' \ + '`destroy_all` will load the rows into memory, then execute a ' \ + '`DELETE` for every individual row.' + + def_node_matcher :destroy_all?, <<~PATTERN + (send {send ivar lvar const} :destroy_all ...) + PATTERN + + def on_send(node) + return unless destroy_all?(node) + + add_offense(node, location: :expression) + end + end + end +end -- cgit v1.2.3