From 9c6c17cbcdb8bf8185fc1b873dcfd08f723e4df5 Mon Sep 17 00:00:00 2001
From: Nick Thomas <nick@gitlab.com>
Date: Wed, 16 Aug 2017 14:04:41 +0100
Subject: Add a minimal GraphQL API

---
 spec/controllers/graphql_controller_spec.rb | 58 +++++++++++++++++++++++++++++
 1 file changed, 58 insertions(+)
 create mode 100644 spec/controllers/graphql_controller_spec.rb

(limited to 'spec/controllers')

diff --git a/spec/controllers/graphql_controller_spec.rb b/spec/controllers/graphql_controller_spec.rb
new file mode 100644
index 00000000000..d6689dbc3c6
--- /dev/null
+++ b/spec/controllers/graphql_controller_spec.rb
@@ -0,0 +1,58 @@
+require 'spec_helper'
+
+describe GraphqlController do
+  describe 'execute' do
+    before do
+      sign_in(user) if user
+
+      run_test_query!
+    end
+
+    subject { query_response }
+
+    context 'graphql is disabled by feature flag' do
+      let(:user) { nil }
+
+      before do
+        stub_feature_flags(graphql: false)
+      end
+
+      it 'returns 404' do
+        run_test_query!
+
+        expect(response).to have_gitlab_http_status(404)
+      end
+    end
+
+    context 'signed out' do
+      let(:user) { nil }
+
+      it 'runs the query with current_user: nil' do
+        is_expected.to eq('echo' => 'nil says: test success')
+      end
+    end
+
+    context 'signed in' do
+      let(:user) { create(:user, username: 'Simon') }
+
+      it 'runs the query with current_user set' do
+        is_expected.to eq('echo' => '"Simon" says: test success')
+      end
+    end
+  end
+
+  # Chosen to exercise all the moving parts in GraphqlController#execute
+  def run_test_query!
+    query = <<~QUERY
+      query Echo($text: String) {
+        echo(text: $text)
+      }
+    QUERY
+
+    post :execute, query: query, operationName: 'Echo', variables: { 'text' => 'test success' }
+  end
+
+  def query_response
+    json_response['data']
+  end
+end
-- 
cgit v1.2.3


From c443133e779c4c508b9c6429dd4ba623d64f03f1 Mon Sep 17 00:00:00 2001
From: Bob Van Landuyt <bob@vanlanduyt.co>
Date: Mon, 21 May 2018 13:42:07 +0200
Subject: Handle exceptions outside the GraphQL schema

This allows us to report JSON parse exceptions to clients and ignore
them in sentry.
---
 spec/controllers/graphql_controller_spec.rb | 15 +++++++++++++--
 1 file changed, 13 insertions(+), 2 deletions(-)

(limited to 'spec/controllers')

diff --git a/spec/controllers/graphql_controller_spec.rb b/spec/controllers/graphql_controller_spec.rb
index d6689dbc3c6..1449036e148 100644
--- a/spec/controllers/graphql_controller_spec.rb
+++ b/spec/controllers/graphql_controller_spec.rb
@@ -2,6 +2,8 @@ require 'spec_helper'
 
 describe GraphqlController do
   describe 'execute' do
+    let(:user) { nil }
+
     before do
       sign_in(user) if user
 
@@ -39,17 +41,26 @@ describe GraphqlController do
         is_expected.to eq('echo' => '"Simon" says: test success')
       end
     end
+
+    context 'invalid variables' do
+      it 'returns an error' do
+        run_test_query!(variables: "This is not JSON")
+
+        expect(response).to have_gitlab_http_status(422)
+        expect(json_response['errors'].first['message']).not_to be_nil
+      end
+    end
   end
 
   # Chosen to exercise all the moving parts in GraphqlController#execute
-  def run_test_query!
+  def run_test_query!(variables: { 'text' => 'test success' })
     query = <<~QUERY
       query Echo($text: String) {
         echo(text: $text)
       }
     QUERY
 
-    post :execute, query: query, operationName: 'Echo', variables: { 'text' => 'test success' }
+    post :execute, query: query, operationName: 'Echo', variables: variables
   end
 
   def query_response
-- 
cgit v1.2.3