From 3db2f327594e134729a0ca2f48a748bb28ab7d6c Mon Sep 17 00:00:00 2001 From: Winnie Hellmann Date: Thu, 5 Jul 2018 06:32:05 +0000 Subject: Enable Capybara/FeatureMethods cop --- spec/features/dashboard/activity_spec.rb | 16 ++++++++-------- spec/features/dashboard/datetime_on_tooltips_spec.rb | 2 +- spec/features/dashboard/groups_list_spec.rb | 2 +- spec/features/dashboard/issues_filter_spec.rb | 2 +- spec/features/dashboard/merge_requests_spec.rb | 2 +- spec/features/dashboard/milestone_filter_spec.rb | 2 +- spec/features/dashboard/milestones_spec.rb | 2 +- .../dashboard/project_member_activity_index_spec.rb | 2 +- spec/features/dashboard/projects_spec.rb | 4 ++-- spec/features/dashboard/shortcuts_spec.rb | 6 +++--- spec/features/dashboard/todos/target_state_spec.rb | 12 ++++++------ spec/features/dashboard/todos/todos_filtering_spec.rb | 2 +- spec/features/dashboard/todos/todos_sorting_spec.rb | 2 +- spec/features/dashboard/todos/todos_spec.rb | 2 +- 14 files changed, 29 insertions(+), 29 deletions(-) (limited to 'spec/features/dashboard') diff --git a/spec/features/dashboard/activity_spec.rb b/spec/features/dashboard/activity_spec.rb index 941208fa244..9ed912820f7 100644 --- a/spec/features/dashboard/activity_spec.rb +++ b/spec/features/dashboard/activity_spec.rb @@ -1,6 +1,6 @@ require 'spec_helper' -feature 'Dashboard > Activity' do +describe 'Dashboard > Activity' do let(:user) { create(:user) } before do @@ -66,7 +66,7 @@ feature 'Dashboard > Activity' do wait_for_requests end - scenario 'user should see all events' do + it 'user should see all events' do within '.content_list' do expect(page).to have_content('pushed new branch') expect(page).to have_content('joined') @@ -77,7 +77,7 @@ feature 'Dashboard > Activity' do end end - scenario 'user should see only pushed events' do + it 'user should see only pushed events' do click_link('Push events') wait_for_requests @@ -90,7 +90,7 @@ feature 'Dashboard > Activity' do end end - scenario 'user should see only merged events' do + it 'user should see only merged events' do click_link('Merge events') wait_for_requests @@ -103,7 +103,7 @@ feature 'Dashboard > Activity' do end end - scenario 'user should see only issues events' do + it 'user should see only issues events' do click_link('Issue events') wait_for_requests @@ -117,7 +117,7 @@ feature 'Dashboard > Activity' do end end - scenario 'user should see only comments events' do + it 'user should see only comments events' do click_link('Comments') wait_for_requests @@ -130,7 +130,7 @@ feature 'Dashboard > Activity' do end end - scenario 'user should see only joined events' do + it 'user should see only joined events' do click_link('Team') wait_for_requests @@ -143,7 +143,7 @@ feature 'Dashboard > Activity' do end end - scenario 'user see selected event after page reloading' do + it 'user see selected event after page reloading' do click_link('Push events') wait_for_requests visit activity_dashboard_path diff --git a/spec/features/dashboard/datetime_on_tooltips_spec.rb b/spec/features/dashboard/datetime_on_tooltips_spec.rb index 089c388636d..28bff4d2821 100644 --- a/spec/features/dashboard/datetime_on_tooltips_spec.rb +++ b/spec/features/dashboard/datetime_on_tooltips_spec.rb @@ -1,6 +1,6 @@ require 'spec_helper' -feature 'Tooltips on .timeago dates', :js do +describe 'Tooltips on .timeago dates', :js do let(:user) { create(:user) } let(:project) { create(:project, name: 'test', namespace: user.namespace) } let(:created_date) { Date.yesterday.to_time } diff --git a/spec/features/dashboard/groups_list_spec.rb b/spec/features/dashboard/groups_list_spec.rb index 29280bd6e06..eceb12e91cd 100644 --- a/spec/features/dashboard/groups_list_spec.rb +++ b/spec/features/dashboard/groups_list_spec.rb @@ -1,6 +1,6 @@ require 'spec_helper' -feature 'Dashboard Groups page', :js do +describe 'Dashboard Groups page', :js do let(:user) { create :user } let(:group) { create(:group) } let(:nested_group) { create(:group, :nested) } diff --git a/spec/features/dashboard/issues_filter_spec.rb b/spec/features/dashboard/issues_filter_spec.rb index 8d0b0be1bd4..340262be502 100644 --- a/spec/features/dashboard/issues_filter_spec.rb +++ b/spec/features/dashboard/issues_filter_spec.rb @@ -1,6 +1,6 @@ require 'spec_helper' -feature 'Dashboard Issues filtering', :js do +describe 'Dashboard Issues filtering', :js do include Spec::Support::Helpers::Features::SortingHelpers let(:user) { create(:user) } diff --git a/spec/features/dashboard/merge_requests_spec.rb b/spec/features/dashboard/merge_requests_spec.rb index 0965b745c03..46d7a82d468 100644 --- a/spec/features/dashboard/merge_requests_spec.rb +++ b/spec/features/dashboard/merge_requests_spec.rb @@ -1,6 +1,6 @@ require 'spec_helper' -feature 'Dashboard Merge Requests' do +describe 'Dashboard Merge Requests' do include Spec::Support::Helpers::Features::SortingHelpers include FilterItemSelectHelper include ProjectForksHelper diff --git a/spec/features/dashboard/milestone_filter_spec.rb b/spec/features/dashboard/milestone_filter_spec.rb index 8cd57f4f327..00373050aeb 100644 --- a/spec/features/dashboard/milestone_filter_spec.rb +++ b/spec/features/dashboard/milestone_filter_spec.rb @@ -1,6 +1,6 @@ require 'spec_helper' -feature 'Dashboard > milestone filter', :js do +describe 'Dashboard > milestone filter', :js do include FilterItemSelectHelper let(:user) { create(:user) } diff --git a/spec/features/dashboard/milestones_spec.rb b/spec/features/dashboard/milestones_spec.rb index 7787772a958..c0699a72521 100644 --- a/spec/features/dashboard/milestones_spec.rb +++ b/spec/features/dashboard/milestones_spec.rb @@ -1,6 +1,6 @@ require 'spec_helper' -feature 'Dashboard > Milestones' do +describe 'Dashboard > Milestones' do describe 'as anonymous user' do before do visit dashboard_milestones_path diff --git a/spec/features/dashboard/project_member_activity_index_spec.rb b/spec/features/dashboard/project_member_activity_index_spec.rb index 6c3093607b0..cfd6329fad0 100644 --- a/spec/features/dashboard/project_member_activity_index_spec.rb +++ b/spec/features/dashboard/project_member_activity_index_spec.rb @@ -1,6 +1,6 @@ require 'spec_helper' -feature 'Project member activity', :js do +describe 'Project member activity', :js do let(:user) { create(:user) } let(:project) { create(:project, :public, name: 'x', namespace: user.namespace) } diff --git a/spec/features/dashboard/projects_spec.rb b/spec/features/dashboard/projects_spec.rb index ef2f0b5b31a..46935662288 100644 --- a/spec/features/dashboard/projects_spec.rb +++ b/spec/features/dashboard/projects_spec.rb @@ -1,6 +1,6 @@ require 'spec_helper' -feature 'Dashboard Projects' do +describe 'Dashboard Projects' do let(:user) { create(:user) } let(:project) { create(:project, :repository, name: 'awesome stuff') } let(:project2) { create(:project, :public, name: 'Community project') } @@ -121,7 +121,7 @@ feature 'Dashboard Projects' do visit dashboard_projects_path end - scenario 'shows "Create merge request" button' do + it 'shows "Create merge request" button' do expect(page).to have_content 'You pushed to feature' within('#content-body') do diff --git a/spec/features/dashboard/shortcuts_spec.rb b/spec/features/dashboard/shortcuts_spec.rb index e41bd7a8419..e5c5ab9c039 100644 --- a/spec/features/dashboard/shortcuts_spec.rb +++ b/spec/features/dashboard/shortcuts_spec.rb @@ -1,13 +1,13 @@ require 'spec_helper' -feature 'Dashboard shortcuts', :js do +describe 'Dashboard shortcuts', :js do context 'logged in' do before do sign_in(create(:user)) visit root_dashboard_path end - scenario 'Navigate to tabs' do + it 'Navigate to tabs' do find('body').send_keys([:shift, 'I']) check_page_title('Issues') @@ -31,7 +31,7 @@ feature 'Dashboard shortcuts', :js do visit explore_root_path end - scenario 'Navigate to tabs' do + it 'Navigate to tabs' do find('body').send_keys([:shift, 'G']) find('.nothing-here-block') diff --git a/spec/features/dashboard/todos/target_state_spec.rb b/spec/features/dashboard/todos/target_state_spec.rb index 030a86d1c01..d55c32b3082 100644 --- a/spec/features/dashboard/todos/target_state_spec.rb +++ b/spec/features/dashboard/todos/target_state_spec.rb @@ -1,6 +1,6 @@ require 'rails_helper' -feature 'Dashboard > Todo target states' do +describe 'Dashboard > Todo target states' do let(:user) { create(:user) } let(:author) { create(:user) } let(:project) { create(:project, :public) } @@ -9,7 +9,7 @@ feature 'Dashboard > Todo target states' do sign_in(user) end - scenario 'on a closed issue todo has closed label' do + it 'on a closed issue todo has closed label' do issue_closed = create(:issue, state: 'closed') create_todo issue_closed visit dashboard_todos_path @@ -19,7 +19,7 @@ feature 'Dashboard > Todo target states' do end end - scenario 'on an open issue todo does not have an open label' do + it 'on an open issue todo does not have an open label' do issue_open = create(:issue) create_todo issue_open visit dashboard_todos_path @@ -29,7 +29,7 @@ feature 'Dashboard > Todo target states' do end end - scenario 'on a merged merge request todo has merged label' do + it 'on a merged merge request todo has merged label' do mr_merged = create(:merge_request, :simple, :merged, author: user) create_todo mr_merged visit dashboard_todos_path @@ -39,7 +39,7 @@ feature 'Dashboard > Todo target states' do end end - scenario 'on a closed merge request todo has closed label' do + it 'on a closed merge request todo has closed label' do mr_closed = create(:merge_request, :simple, :closed, author: user) create_todo mr_closed visit dashboard_todos_path @@ -49,7 +49,7 @@ feature 'Dashboard > Todo target states' do end end - scenario 'on an open merge request todo does not have an open label' do + it 'on an open merge request todo does not have an open label' do mr_open = create(:merge_request, :simple, author: user) create_todo mr_open visit dashboard_todos_path diff --git a/spec/features/dashboard/todos/todos_filtering_spec.rb b/spec/features/dashboard/todos/todos_filtering_spec.rb index 7b359b0c651..85f865321cf 100644 --- a/spec/features/dashboard/todos/todos_filtering_spec.rb +++ b/spec/features/dashboard/todos/todos_filtering_spec.rb @@ -1,6 +1,6 @@ require 'spec_helper' -feature 'Dashboard > User filters todos', :js do +describe 'Dashboard > User filters todos', :js do let(:user_1) { create(:user, username: 'user_1', name: 'user_1') } let(:user_2) { create(:user, username: 'user_2', name: 'user_2') } diff --git a/spec/features/dashboard/todos/todos_sorting_spec.rb b/spec/features/dashboard/todos/todos_sorting_spec.rb index 10e3ad843fd..b87caaa1c07 100644 --- a/spec/features/dashboard/todos/todos_sorting_spec.rb +++ b/spec/features/dashboard/todos/todos_sorting_spec.rb @@ -1,6 +1,6 @@ require 'spec_helper' -feature 'Dashboard > User sorts todos' do +describe 'Dashboard > User sorts todos' do let(:user) { create(:user) } let(:project) { create(:project) } diff --git a/spec/features/dashboard/todos/todos_spec.rb b/spec/features/dashboard/todos/todos_spec.rb index 5ed20b02a6e..96b22a0f64b 100644 --- a/spec/features/dashboard/todos/todos_spec.rb +++ b/spec/features/dashboard/todos/todos_spec.rb @@ -1,6 +1,6 @@ require 'spec_helper' -feature 'Dashboard Todos' do +describe 'Dashboard Todos' do let(:user) { create(:user) } let(:author) { create(:user) } let(:project) { create(:project, :public) } -- cgit v1.2.3