From 26d3da4bfe5c4718d3dfb4407cee58da53b408aa Mon Sep 17 00:00:00 2001 From: Tiago Botelho Date: Mon, 13 Mar 2017 16:00:07 +0000 Subject: removes n+1 query from tags and branches indexes --- spec/features/tags/master_views_tags_spec.rb | 10 ++++++++++ 1 file changed, 10 insertions(+) (limited to 'spec/features/tags') diff --git a/spec/features/tags/master_views_tags_spec.rb b/spec/features/tags/master_views_tags_spec.rb index 29d2c244720..555f84c4772 100644 --- a/spec/features/tags/master_views_tags_spec.rb +++ b/spec/features/tags/master_views_tags_spec.rb @@ -27,10 +27,20 @@ feature 'Master views tags', feature: true do context 'when project has tags' do let(:project) { create(:project, namespace: user.namespace) } + let(:repository) { project.repository } + before do visit namespace_project_tags_path(project.namespace, project) end + scenario 'avoids a N+1 query in branches index' do + control_count = ActiveRecord::QueryRecorder.new { visit namespace_project_tags_path(project.namespace, project) }.count + + %w(one two three four five).each { |tag| repository.add_tag(user, tag, 'master', 'foo') } + + expect { visit namespace_project_tags_path(project.namespace, project) }.not_to exceed_query_limit(control_count) + end + scenario 'views the tags list page' do expect(page).to have_content 'v1.0.0' end -- cgit v1.2.3