From f2005125dfe7810de910b61dee8d7a9203a6ca6e Mon Sep 17 00:00:00 2001 From: Stan Hu Date: Thu, 23 Aug 2018 15:21:06 -0700 Subject: Use slugs for default project path and sanitize names before import Users importing from Bitbucket Cloud, Bitbucket Server, or GitHub often complained about getting failed imports due to 422 errors. This change ensures that project names are imported with names that are guaranteed to pass the regular expression validation. Part of #50021 --- spec/helpers/import_helper_spec.rb | 10 ++++++++++ 1 file changed, 10 insertions(+) (limited to 'spec/helpers/import_helper_spec.rb') diff --git a/spec/helpers/import_helper_spec.rb b/spec/helpers/import_helper_spec.rb index 033155617c6..cb0ea4e26ba 100644 --- a/spec/helpers/import_helper_spec.rb +++ b/spec/helpers/import_helper_spec.rb @@ -1,6 +1,16 @@ require 'rails_helper' describe ImportHelper do + describe '#sanitize_project_name' do + it 'removes whitespace' do + expect(helper.sanitize_project_name('my test repo')).to eq('my-test-repo') + end + + it 'removes disallowed characters' do + expect(helper.sanitize_project_name('Test&me$over*h_ere')).to eq('Test-me-over-h_ere') + end + end + describe '#import_project_target' do let(:user) { create(:user) } -- cgit v1.2.3