From 9bb0d0b4079bc88134399f175ce9631005044060 Mon Sep 17 00:00:00 2001 From: Stan Hu Date: Sun, 22 May 2016 23:35:18 -0700 Subject: Fix Error 500 in CI charts by gracefully handling commits with no durations Closes #17730 --- spec/lib/ci/charts_spec.rb | 7 +++++++ 1 file changed, 7 insertions(+) (limited to 'spec/lib/ci') diff --git a/spec/lib/ci/charts_spec.rb b/spec/lib/ci/charts_spec.rb index 50a77308cde..9d1215a5760 100644 --- a/spec/lib/ci/charts_spec.rb +++ b/spec/lib/ci/charts_spec.rb @@ -12,5 +12,12 @@ describe Ci::Charts, lib: true do chart = Ci::Charts::BuildTime.new(@commit.project) expect(chart.build_times).to eq([2]) end + + it 'should handle nil build times' do + create(:ci_commit, duration: nil, project: @commit.project) + + chart = Ci::Charts::BuildTime.new(@commit.project) + expect(chart.build_times).to eq([2, 0]) + end end end -- cgit v1.2.3