From 9f0b46c05aef9d0352bfaa5e42e34143227de8ff Mon Sep 17 00:00:00 2001 From: Grzegorz Bizon Date: Wed, 10 Aug 2016 14:12:31 +0200 Subject: Move badges to separate modules and add base class --- spec/lib/gitlab/badge/build/status_spec.rb | 106 ++++++++++++++++++++++++++ spec/lib/gitlab/badge/build_spec.rb | 106 -------------------------- spec/lib/gitlab/badge/coverage/report_spec.rb | 21 +++++ spec/lib/gitlab/badge/coverage_spec.rb | 19 ----- 4 files changed, 127 insertions(+), 125 deletions(-) create mode 100644 spec/lib/gitlab/badge/build/status_spec.rb delete mode 100644 spec/lib/gitlab/badge/build_spec.rb create mode 100644 spec/lib/gitlab/badge/coverage/report_spec.rb delete mode 100644 spec/lib/gitlab/badge/coverage_spec.rb (limited to 'spec/lib/gitlab/badge') diff --git a/spec/lib/gitlab/badge/build/status_spec.rb b/spec/lib/gitlab/badge/build/status_spec.rb new file mode 100644 index 00000000000..fa5bc068918 --- /dev/null +++ b/spec/lib/gitlab/badge/build/status_spec.rb @@ -0,0 +1,106 @@ +require 'spec_helper' + +describe Gitlab::Badge::Build::Status do + let(:project) { create(:project) } + let(:sha) { project.commit.sha } + let(:branch) { 'master' } + let(:badge) { described_class.new(project, branch) } + + describe '#metadata' do + it 'returns badge metadata' do + expect(badge.metadata.image_url) + .to include 'badges/master/build.svg' + end + end + + describe '#key_text' do + it 'always says build' do + expect(badge.key_text).to eq 'build' + end + end + + context 'build exists' do + let!(:build) { create_build(project, sha, branch) } + + context 'build success' do + before { build.success! } + + describe '#status' do + it 'is successful' do + expect(badge.status).to eq 'success' + end + end + + describe '#value_text' do + it 'returns correct value text' do + expect(badge.value_text).to eq 'success' + end + end + end + + context 'build failed' do + before { build.drop! } + + describe '#status' do + it 'failed' do + expect(badge.status).to eq 'failed' + end + end + + describe '#value_text' do + it 'has correct value text' do + expect(badge.value_text).to eq 'failed' + end + end + end + + context 'when outdated pipeline for given ref exists' do + before do + build.success! + + old_build = create_build(project, '11eeffdd', branch) + old_build.drop! + end + + it 'does not take outdated pipeline into account' do + expect(badge.status).to eq 'success' + end + end + + context 'when multiple pipelines exist for given sha' do + before do + build.drop! + + new_build = create_build(project, sha, branch) + new_build.success! + end + + it 'reports the compound status' do + expect(badge.status).to eq 'failed' + end + end + end + + context 'build does not exist' do + describe '#status' do + it 'is unknown' do + expect(badge.status).to eq 'unknown' + end + end + + describe '#value_text' do + it 'has correct value text' do + expect(badge.value_text).to eq 'unknown' + end + end + end + + def create_build(project, sha, branch) + pipeline = create(:ci_empty_pipeline, + project: project, + sha: sha, + ref: branch) + + create(:ci_build, pipeline: pipeline, stage: 'notify') + end +end diff --git a/spec/lib/gitlab/badge/build_spec.rb b/spec/lib/gitlab/badge/build_spec.rb deleted file mode 100644 index bb8144d5122..00000000000 --- a/spec/lib/gitlab/badge/build_spec.rb +++ /dev/null @@ -1,106 +0,0 @@ -require 'spec_helper' - -describe Gitlab::Badge::Build do - let(:project) { create(:project) } - let(:sha) { project.commit.sha } - let(:branch) { 'master' } - let(:badge) { described_class.new(project, branch) } - - describe '#metadata' do - it 'returns badge metadata' do - expect(badge.metadata.image_url) - .to include 'badges/master/build.svg' - end - end - - describe '#key_text' do - it 'always says build' do - expect(badge.key_text).to eq 'build' - end - end - - context 'build exists' do - let!(:build) { create_build(project, sha, branch) } - - context 'build success' do - before { build.success! } - - describe '#status' do - it 'is successful' do - expect(badge.status).to eq 'success' - end - end - - describe '#value_text' do - it 'returns correct value text' do - expect(badge.value_text).to eq 'success' - end - end - end - - context 'build failed' do - before { build.drop! } - - describe '#status' do - it 'failed' do - expect(badge.status).to eq 'failed' - end - end - - describe '#value_text' do - it 'has correct value text' do - expect(badge.value_text).to eq 'failed' - end - end - end - - context 'when outdated pipeline for given ref exists' do - before do - build.success! - - old_build = create_build(project, '11eeffdd', branch) - old_build.drop! - end - - it 'does not take outdated pipeline into account' do - expect(badge.status).to eq 'success' - end - end - - context 'when multiple pipelines exist for given sha' do - before do - build.drop! - - new_build = create_build(project, sha, branch) - new_build.success! - end - - it 'reports the compound status' do - expect(badge.status).to eq 'failed' - end - end - end - - context 'build does not exist' do - describe '#status' do - it 'is unknown' do - expect(badge.status).to eq 'unknown' - end - end - - describe '#value_text' do - it 'has correct value text' do - expect(badge.value_text).to eq 'unknown' - end - end - end - - def create_build(project, sha, branch) - pipeline = create(:ci_empty_pipeline, - project: project, - sha: sha, - ref: branch) - - create(:ci_build, pipeline: pipeline, stage: 'notify') - end -end diff --git a/spec/lib/gitlab/badge/coverage/report_spec.rb b/spec/lib/gitlab/badge/coverage/report_spec.rb new file mode 100644 index 00000000000..57b89dd8cda --- /dev/null +++ b/spec/lib/gitlab/badge/coverage/report_spec.rb @@ -0,0 +1,21 @@ +require 'spec_helper' + +describe Gitlab::Badge::Coverage::Report do + let(:project) { create(:project) } + + let(:pipeline) do + create(:ci_pipeline, project: project, + sha: project.commit.id, + ref: 'master') + end + + let(:badge) do + described_class.new(project, 'master') + end + + context 'builds exist' do + end + + context 'builds do not exist' do + end +end diff --git a/spec/lib/gitlab/badge/coverage_spec.rb b/spec/lib/gitlab/badge/coverage_spec.rb deleted file mode 100644 index 343ca3c0f85..00000000000 --- a/spec/lib/gitlab/badge/coverage_spec.rb +++ /dev/null @@ -1,19 +0,0 @@ -require 'spec_helper' - -describe Gitlab::Badge::Coverage do - let(:project) { create(:project) } - - let(:pipeline) do - create(:ci_pipeline, project: project, - sha: project.commit.id, - ref: 'master') - end - - let(:badge) { described_class.new(project, 'master') } - - context 'builds exist' do - end - - context 'build does not exist' do - end -end -- cgit v1.2.3