From ffc9fe49a15e68c8251082fa6ac75a57350640ed Mon Sep 17 00:00:00 2001 From: Vladimir Shushlin Date: Mon, 21 Jan 2019 14:08:42 +0300 Subject: Fix empty labels for `pages:deploy` job Use description of GenericCommitStatus as label if provided Fallback to core status labels if not --- spec/lib/gitlab/ci/status/external/common_spec.rb | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) (limited to 'spec/lib/gitlab/ci/status') diff --git a/spec/lib/gitlab/ci/status/external/common_spec.rb b/spec/lib/gitlab/ci/status/external/common_spec.rb index 40871f86568..44e73eadc72 100644 --- a/spec/lib/gitlab/ci/status/external/common_spec.rb +++ b/spec/lib/gitlab/ci/status/external/common_spec.rb @@ -11,7 +11,7 @@ describe Gitlab::Ci::Status::External::Common do end subject do - Gitlab::Ci::Status::Core + Gitlab::Ci::Status::Success .new(external_status, user) .extend(described_class) end @@ -20,6 +20,14 @@ describe Gitlab::Ci::Status::External::Common do it 'returns description' do expect(subject.label).to eq external_description end + + context 'when description is not set' do + let(:external_description) { nil } + + it 'uses core status label' do + expect(subject.label).to eq('passed') + end + end end describe '#has_action?' do -- cgit v1.2.3