From 350f19f59fd1e44c18699cc46cfff71a92d7e0a4 Mon Sep 17 00:00:00 2001 From: Stan Hu Date: Sat, 8 Jun 2019 07:12:47 -0700 Subject: Bump omniauth_openid_connect to 0.3.1 In https://gitlab.com/gitlab-org/gitlab-ce/issues/62208, users were seeing 404 errors when they configured their OpenID provider without a name parameter since OmniAuth would use the name `openidconnect` instead `openid_connect`. https://github.com/m0n9oose/omniauth_openid_connect/pull/23 makes the default parameter `openid_connect` so this additional initializer in GitLab is not necessary. Plus, this change enables users to use multiple OpenID Connect providers if they desire. --- spec/lib/gitlab/omniauth_initializer_spec.rb | 8 -------- 1 file changed, 8 deletions(-) (limited to 'spec/lib/gitlab/omniauth_initializer_spec.rb') diff --git a/spec/lib/gitlab/omniauth_initializer_spec.rb b/spec/lib/gitlab/omniauth_initializer_spec.rb index 32296caf819..f9c0daf1ef1 100644 --- a/spec/lib/gitlab/omniauth_initializer_spec.rb +++ b/spec/lib/gitlab/omniauth_initializer_spec.rb @@ -83,13 +83,5 @@ describe Gitlab::OmniauthInitializer do subject.execute([cas3_config]) end - - it 'configures name for openid_connect' do - openid_connect_config = { 'name' => 'openid_connect', 'args' => {} } - - expect(devise_config).to receive(:omniauth).with(:openid_connect, name: 'openid_connect') - - subject.execute([openid_connect_config]) - end end end -- cgit v1.2.3