From 85dc423f7090da0a52c73eb66faf22ddb20efff9 Mon Sep 17 00:00:00 2001 From: GitLab Bot Date: Sat, 19 Sep 2020 01:45:44 +0000 Subject: Add latest changes from gitlab-org/gitlab@13-4-stable-ee --- spec/lib/gitlab/sql/except_spec.rb | 7 +++++++ spec/lib/gitlab/sql/intersect_spec.rb | 7 +++++++ spec/lib/gitlab/sql/union_spec.rb | 37 +---------------------------------- 3 files changed, 15 insertions(+), 36 deletions(-) create mode 100644 spec/lib/gitlab/sql/except_spec.rb create mode 100644 spec/lib/gitlab/sql/intersect_spec.rb (limited to 'spec/lib/gitlab/sql') diff --git a/spec/lib/gitlab/sql/except_spec.rb b/spec/lib/gitlab/sql/except_spec.rb new file mode 100644 index 00000000000..a3d6990ee2e --- /dev/null +++ b/spec/lib/gitlab/sql/except_spec.rb @@ -0,0 +1,7 @@ +# frozen_string_literal: true + +require 'spec_helper' + +RSpec.describe Gitlab::SQL::Except do + it_behaves_like 'SQL set operator', 'EXCEPT' +end diff --git a/spec/lib/gitlab/sql/intersect_spec.rb b/spec/lib/gitlab/sql/intersect_spec.rb new file mode 100644 index 00000000000..cf076796712 --- /dev/null +++ b/spec/lib/gitlab/sql/intersect_spec.rb @@ -0,0 +1,7 @@ +# frozen_string_literal: true + +require 'spec_helper' + +RSpec.describe Gitlab::SQL::Intersect do + it_behaves_like 'SQL set operator', 'INTERSECT' +end diff --git a/spec/lib/gitlab/sql/union_spec.rb b/spec/lib/gitlab/sql/union_spec.rb index c8be83c093d..a41551e25bf 100644 --- a/spec/lib/gitlab/sql/union_spec.rb +++ b/spec/lib/gitlab/sql/union_spec.rb @@ -3,40 +3,5 @@ require 'spec_helper' RSpec.describe Gitlab::SQL::Union do - let(:relation_1) { User.where(email: 'alice@example.com').select(:id) } - let(:relation_2) { User.where(email: 'bob@example.com').select(:id) } - - def to_sql(relation) - relation.reorder(nil).to_sql - end - - describe '#to_sql' do - it 'returns a String joining relations together using a UNION' do - union = described_class.new([relation_1, relation_2]) - - expect(union.to_sql).to eq("(#{to_sql(relation_1)})\nUNION\n(#{to_sql(relation_2)})") - end - - it 'skips Model.none segements' do - empty_relation = User.none - union = described_class.new([empty_relation, relation_1, relation_2]) - - expect {User.where("users.id IN (#{union.to_sql})").to_a}.not_to raise_error - expect(union.to_sql).to eq("(#{to_sql(relation_1)})\nUNION\n(#{to_sql(relation_2)})") - end - - it 'uses UNION ALL when removing duplicates is disabled' do - union = described_class - .new([relation_1, relation_2], remove_duplicates: false) - - expect(union.to_sql).to include('UNION ALL') - end - - it 'returns `NULL` if all relations are empty' do - empty_relation = User.none - union = described_class.new([empty_relation, empty_relation]) - - expect(union.to_sql).to eq('NULL') - end - end + it_behaves_like 'SQL set operator', 'UNION' end -- cgit v1.2.3