From c92808ed323d70c6af00cd19fb5e4ed35ce9957d Mon Sep 17 00:00:00 2001 From: Toon Claes Date: Thu, 9 Mar 2017 16:39:09 +0100 Subject: Fix for creating a project through API when import_url is nil The API was returning 500 when `nil` is passed for the `import_url`. In fact, it was `Gitlab::UrlSanitizer.valid?` which was throwing a `NoMethodError` when `nil` value was passed. --- spec/lib/gitlab/url_sanitizer_spec.rb | 8 ++++++++ 1 file changed, 8 insertions(+) (limited to 'spec/lib/gitlab/url_sanitizer_spec.rb') diff --git a/spec/lib/gitlab/url_sanitizer_spec.rb b/spec/lib/gitlab/url_sanitizer_spec.rb index 2cb74629da8..3fd361de458 100644 --- a/spec/lib/gitlab/url_sanitizer_spec.rb +++ b/spec/lib/gitlab/url_sanitizer_spec.rb @@ -70,4 +70,12 @@ describe Gitlab::UrlSanitizer, lib: true do expect(sanitizer.full_url).to eq('user@server:project.git') end end + + describe '.valid?' do + it 'validates url strings' do + expect(described_class.valid?(nil)).to be(false) + expect(described_class.valid?('valid@project:url.git')).to be(true) + expect(described_class.valid?('123://invalid:url')).to be(false) + end + end end -- cgit v1.2.3