From 37cfaf27abf714252c48765b0e78f25dc4bcf641 Mon Sep 17 00:00:00 2001
From: Ash McKenzie <amckenzie@gitlab.com>
Date: Wed, 7 Aug 2019 17:51:12 +1000
Subject: Extract /internal/allowed API Actor logic out

Created new API::Support::GitAccessActor class to
encapsulate some of the more edge logic, making
the /internal/allowed route much cleaner.
---
 spec/lib/api/support/git_access_actor_spec.rb | 128 ++++++++++++++++++++++++++
 1 file changed, 128 insertions(+)
 create mode 100644 spec/lib/api/support/git_access_actor_spec.rb

(limited to 'spec/lib')

diff --git a/spec/lib/api/support/git_access_actor_spec.rb b/spec/lib/api/support/git_access_actor_spec.rb
new file mode 100644
index 00000000000..63f5966faea
--- /dev/null
+++ b/spec/lib/api/support/git_access_actor_spec.rb
@@ -0,0 +1,128 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+describe API::Support::GitAccessActor do
+  let(:user) { nil }
+  let(:key) { nil }
+
+  subject { described_class.new(user: user, key: key) }
+
+  describe '.from_params' do
+    context 'with params that are valid' do
+      it 'returns an instance of API::Support::GitAccessActor' do
+        params = { key_id: create(:key).id }
+
+        expect(described_class.from_params(params)).to be_instance_of(described_class)
+      end
+    end
+
+    context 'with params that are invalid' do
+      it 'returns nil' do
+        expect(described_class.from_params({})).to be_nil
+      end
+    end
+  end
+
+  describe 'attributes' do
+    describe '#user' do
+      context 'when initialized with a User' do
+        let(:user) { create(:user) }
+
+        it 'returns the User' do
+          expect(subject.user).to eq(user)
+        end
+      end
+
+      context 'when initialized with a Key' do
+        let(:user_for_key) { create(:user) }
+        let(:key) { create(:key, user: user_for_key) }
+
+        it 'returns the User associated to the Key' do
+          expect(subject.user).to eq(user_for_key)
+        end
+      end
+    end
+  end
+
+  describe '#key_or_user' do
+    context 'when params contains a :key_id' do
+      it 'is an instance of Key' do
+        key = create(:key)
+        params = { key_id: key.id }
+
+        expect(described_class.from_params(params).key_or_user).to eq(key)
+      end
+    end
+
+    context 'when params contains a :user_id' do
+      it 'is an instance of User' do
+        user = create(:user)
+        params = { user_id: user.id }
+
+        expect(described_class.from_params(params).key_or_user).to eq(user)
+      end
+    end
+
+    context 'when params contains a :username' do
+      it 'is an instance of User (via UserFinder)' do
+        user = create(:user)
+        params = { username: user.username }
+
+        expect(described_class.from_params(params).key_or_user).to eq(user)
+      end
+    end
+  end
+
+  describe '#username' do
+    context 'when initialized with a User' do
+      let(:user) { create(:user) }
+
+      it 'returns the username' do
+        expect(subject.username).to eq(user.username)
+      end
+    end
+
+    context 'when initialized with a Key' do
+      let(:key) { create(:key, user: user_for_key) }
+
+      context 'that has no User associated' do
+        let(:user_for_key) { nil }
+
+        it 'returns nil' do
+          expect(subject.username).to be_nil
+        end
+      end
+
+      context 'that has a User associated' do
+        let(:user_for_key) { create(:user) }
+
+        it 'returns the username of the User associated to the Key' do
+          expect(subject.username).to eq(user_for_key.username)
+        end
+      end
+    end
+  end
+
+  describe '#update_last_used_at!' do
+    context 'when initialized with a User' do
+      let(:user) { create(:user) }
+
+      it 'does nothing' do
+        expect(user).not_to receive(:update_last_used_at)
+
+        subject.update_last_used_at!
+      end
+    end
+
+    context 'when initialized with a Key' do
+      let(:key) { create(:key) }
+
+      it 'updates update_last_used_at' do
+        expect(key).to receive(:update_last_used_at)
+
+        subject.update_last_used_at!
+      end
+    end
+  end
+end
-- 
cgit v1.2.3