From ddc7620babba20e55c535628e7c6a7c6046176bf Mon Sep 17 00:00:00 2001 From: blackst0ne Date: Sun, 29 Apr 2018 22:50:39 +1100 Subject: [Rails5] Fix `undefined method 'downcase'` errors in requests specs In Rails 5.0 headers are no longer inherited from Hash. This commit fixes errors in requests specs like: ``` 1) API::V3::Builds GET /projects/:id/builds/:build_id/artifacts job with artifacts when artifacts are stored locally authorized user returns specific job artifacts Failure/Error: expect(response.headers).to include(download_headers) NoMethodError: undefined method `downcase' for # # ./spec/requests/api/v3/builds_spec.rb:235:in `block (6 levels) in ' ``` --- spec/requests/api/jobs_spec.rb | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'spec/requests/api/jobs_spec.rb') diff --git a/spec/requests/api/jobs_spec.rb b/spec/requests/api/jobs_spec.rb index 3ffdfdc0e9a..0a2963452e4 100644 --- a/spec/requests/api/jobs_spec.rb +++ b/spec/requests/api/jobs_spec.rb @@ -281,7 +281,7 @@ describe API::Jobs do get_artifact_file(artifact) expect(response).to have_gitlab_http_status(200) - expect(response.headers) + expect(response.headers.to_h) .to include('Content-Type' => 'application/json', 'Gitlab-Workhorse-Send-Data' => /artifacts-entry/) end @@ -311,7 +311,7 @@ describe API::Jobs do it 'returns specific job artifacts' do expect(response).to have_gitlab_http_status(200) - expect(response.headers).to include(download_headers) + expect(response.headers.to_h).to include(download_headers) expect(response.body).to match_file(job.artifacts_file.file.file) end end @@ -462,7 +462,7 @@ describe API::Jobs do end it { expect(response).to have_http_status(:ok) } - it { expect(response.headers).to include(download_headers) } + it { expect(response.headers.to_h).to include(download_headers) } end context 'when artifacts are stored remotely' do -- cgit v1.2.3