From 9c87275f6ef0b40d905929ce5bcd5480a6dfd369 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=F0=9F=99=88=20=20jacopo=20beschi=20=F0=9F=99=89?=
 <intrip@gmail.com>
Date: Wed, 4 Sep 2019 20:13:39 +0000
Subject: Show meaningful message on /due quick action with invalid date

When using /due quick action with an invalid date a meaninful error
message is shown.
---
 .../quick_actions/interpret_service_spec.rb        | 61 ++++++++++++----------
 1 file changed, 33 insertions(+), 28 deletions(-)

(limited to 'spec/services/quick_actions')

diff --git a/spec/services/quick_actions/interpret_service_spec.rb b/spec/services/quick_actions/interpret_service_spec.rb
index c9714964fc9..6ca0a3fa448 100644
--- a/spec/services/quick_actions/interpret_service_spec.rb
+++ b/spec/services/quick_actions/interpret_service_spec.rb
@@ -970,34 +970,6 @@ describe QuickActions::InterpretService do
       let(:issuable) { merge_request }
     end
 
-    it_behaves_like 'due command' do
-      let(:content) { '/due 2016-08-28' }
-      let(:issuable) { issue }
-    end
-
-    it_behaves_like 'due command' do
-      let(:content) { '/due tomorrow' }
-      let(:issuable) { issue }
-      let(:expected_date) { Date.tomorrow }
-    end
-
-    it_behaves_like 'due command' do
-      let(:content) { '/due 5 days from now' }
-      let(:issuable) { issue }
-      let(:expected_date) { 5.days.from_now.to_date }
-    end
-
-    it_behaves_like 'due command' do
-      let(:content) { '/due in 2 days' }
-      let(:issuable) { issue }
-      let(:expected_date) { 2.days.from_now.to_date }
-    end
-
-    it_behaves_like 'empty command' do
-      let(:content) { '/due foo bar' }
-      let(:issuable) { issue }
-    end
-
     it_behaves_like 'empty command' do
       let(:content) { '/due 2016-08-28' }
       let(:issuable) { merge_request }
@@ -1131,6 +1103,39 @@ describe QuickActions::InterpretService do
       end
     end
 
+    context '/due command' do
+      it 'returns invalid date format message when the due date is invalid' do
+        issue = build(:issue, project: project)
+
+        _, _, message = service.execute('/due invalid date', issue)
+
+        expect(message).to eq('Failed to set due date because the date format is invalid.')
+      end
+
+      it_behaves_like 'due command' do
+        let(:content) { '/due 2016-08-28' }
+        let(:issuable) { issue }
+      end
+
+      it_behaves_like 'due command' do
+        let(:content) { '/due tomorrow' }
+        let(:issuable) { issue }
+        let(:expected_date) { Date.tomorrow }
+      end
+
+      it_behaves_like 'due command' do
+        let(:content) { '/due 5 days from now' }
+        let(:issuable) { issue }
+        let(:expected_date) { 5.days.from_now.to_date }
+      end
+
+      it_behaves_like 'due command' do
+        let(:content) { '/due in 2 days' }
+        let(:issuable) { issue }
+        let(:expected_date) { 2.days.from_now.to_date }
+      end
+    end
+
     context '/copy_metadata command' do
       let(:todo_label) { create(:label, project: project, title: 'To Do') }
       let(:inreview_label) { create(:label, project: project, title: 'In Review') }
-- 
cgit v1.2.3