From 76cfe4f1fdadf0b4e43d066ffccbe34fbfcb9a80 Mon Sep 17 00:00:00 2001 From: DJ Mountney Date: Tue, 11 Sep 2018 18:41:14 -0700 Subject: Ensure the schema is loaded with post_migrations included If doing a schema load, the post_migrations should also be marked as up, even if SKIP_POST_DEPLOYMENT_MIGRATIONS was set, otherwise future migration runs will be broken. --- spec/tasks/gitlab/db_rake_spec.rb | 29 +++++++++++++++++++++++++++++ 1 file changed, 29 insertions(+) (limited to 'spec/tasks') diff --git a/spec/tasks/gitlab/db_rake_spec.rb b/spec/tasks/gitlab/db_rake_spec.rb index b81aea23306..5e0300066d1 100644 --- a/spec/tasks/gitlab/db_rake_spec.rb +++ b/spec/tasks/gitlab/db_rake_spec.rb @@ -61,6 +61,35 @@ describe 'gitlab:db namespace rake task' do expect(Rake::Task['db:migrate']).not_to receive(:invoke) expect { run_rake_task('gitlab:db:configure') }.to raise_error(RuntimeError, 'error') end + + context 'SKIP_POST_DEPLOYMENT_MIGRATIONS environment variable set' do + let :migrations_paths do + root = Rails::Paths::Root.new(Rails.root) + root.add('db/migrate') + end + + before do + allow(ENV).to receive(:[]).and_call_original + allow(ENV).to receive(:[]).with('SKIP_POST_DEPLOYMENT_MIGRATIONS').and_return true + + # Our environment has already been loaded, so we need to pretent like post_migrations were not + allow(Rails.application.config.paths).to receive(:[]).and_call_original + allow(Rails.application.config.paths).to receive(:[]).with('db/migrate').and_return(migrations_paths) + allow(ActiveRecord::Migrator).to receive(:migrations_paths).and_return(migrations_paths) + end + + it 'adds post deployment migrations before schema load if the schema is not already loaded' do + allow(ActiveRecord::Base.connection).to receive(:tables).and_return([]) + expect(Gitlab::Database).to receive(:add_post_migrate_path_to_rails) + expect(Rake::Task['db:schema:load']).to receive(:invoke) + expect(Rake::Task['db:seed_fu']).to receive(:invoke) + expect(Rake::Task['db:migrate']).not_to receive(:invoke) + expect(Rails.application.config.paths).to receive(:[]).with('db/migrate') + expect { run_rake_task('gitlab:db:configure') }.not_to raise_error + + expect(migrations_paths.include?(File.join(Rails.root, 'db', 'post_migrate'))).to be(true) + end + end end def run_rake_task(task_name) -- cgit v1.2.3