From 180e88bbfbdd93939ec2c37e457207f29fd6ccfd Mon Sep 17 00:00:00 2001 From: GitLab Bot Date: Tue, 25 Jul 2023 15:09:47 +0000 Subject: Add latest changes from gitlab-org/gitlab@master --- spec/tooling/danger/bulk_database_actions_spec.rb | 109 ++++++++++++++++++++++ 1 file changed, 109 insertions(+) create mode 100644 spec/tooling/danger/bulk_database_actions_spec.rb (limited to 'spec/tooling') diff --git a/spec/tooling/danger/bulk_database_actions_spec.rb b/spec/tooling/danger/bulk_database_actions_spec.rb new file mode 100644 index 00000000000..584730ba308 --- /dev/null +++ b/spec/tooling/danger/bulk_database_actions_spec.rb @@ -0,0 +1,109 @@ +# frozen_string_literal: true + +require 'gitlab-dangerfiles' +require 'danger' +require 'danger/plugins/internal/helper' +require 'gitlab/dangerfiles/spec_helper' +require 'rspec-parameterized' + +require_relative '../../../tooling/danger/bulk_database_actions' +require_relative '../../../tooling/danger/project_helper' + +RSpec.describe Tooling::Danger::BulkDatabaseActions, feature_category: :tooling do + include_context "with dangerfile" + + let(:fake_danger) { DangerSpecHelper.fake_danger.include(described_class) } + let(:fake_project_helper) { instance_double(Tooling::Danger::ProjectHelper) } + + let(:mr_url) { 'https://gitlab.com/gitlab-org/gitlab/-/merge_requests/1' } + let(:doc_link) { described_class::DOCUMENTATION_LINK } + + let(:comment_text) { "\n#{described_class::COMMENT_TEXT}" } + + let(:file_lines) do + file_diff.map { |line| line.delete_prefix('+') } + end + + let(:file_diff) do + [ + "+ def execute", + "+ pat_family.active.#{method_call}", + "+", + "+ ServiceResponse.success", + "+ end" + ] + end + + before do + allow(bulk_database_actions).to receive(:project_helper).and_return(fake_project_helper) + allow(bulk_database_actions.project_helper).to receive(:file_lines).and_return(file_lines) + allow(bulk_database_actions.helper).to receive(:added_files).and_return([filename]) + allow(bulk_database_actions.helper).to receive(:changed_lines).with(filename).and_return(file_diff) + allow(bulk_database_actions.helper).to receive(:mr_web_url).and_return(mr_url) + end + + subject(:bulk_database_actions) { fake_danger.new(helper: fake_helper) } + + describe '#add_comment_for_bulk_database_action_method_usage' do + context 'when file is a non-spec Ruby file' do + let(:filename) { 'app/services/personal_access_tokens/revoke_token_family_service.rb' } + + using RSpec::Parameterized::TableSyntax + + where(:method_call, :expect_comment?) do + 'update_all(revoked: true)' | true + 'destroy_all' | true + 'delete_all' | true + 'update(revoked: true)' | true + 'delete' | true + 'update_two_factor' | false + 'delete_keys(key)' | false + 'destroy_hook(hook)' | false + 'destroy_all_merged' | false + 'update_all_mirrors' | false + end + + with_them do + it "correctly handles potential bulk database action" do + if expect_comment? + expect(bulk_database_actions).to receive(:markdown).with(comment_text, file: filename, line: 2) + else + expect(bulk_database_actions).not_to receive(:markdown) + end + + bulk_database_actions.add_comment_for_bulk_database_action_method_usage + end + end + end + + context 'for spec directories' do + let(:method_call) { 'update_all(revoked: true)' } + + shared_examples 'no Danger comment' do + it 'does not comment on the bulk update action usage' do + expect(bulk_database_actions).not_to receive(:markdown) + + bulk_database_actions.add_comment_for_bulk_database_action_method_usage + end + end + + context 'for FOSS spec file' do + let(:filename) { 'spec/services/personal_access_tokens/revoke_token_family_service_spec.rb' } + + it_behaves_like 'no Danger comment' + end + + context 'for EE spec file' do + let(:filename) { 'ee/spec/services/personal_access_tokens/revoke_token_family_service_spec.rb' } + + it_behaves_like 'no Danger comment' + end + + context 'for JiHu spec file' do + let(:filename) { 'jh/spec/services/personal_access_tokens/revoke_token_family_service_spec.rb' } + + it_behaves_like 'no Danger comment' + end + end + end +end -- cgit v1.2.3