From 0e613db76d8d6e8521a3b4d546f552c8d184ffa1 Mon Sep 17 00:00:00 2001 From: Grzegorz Bizon Date: Tue, 26 Apr 2016 11:59:41 +0200 Subject: Add more validation tests for note model --- spec/models/note_spec.rb | 27 +++++++++++++++++++++++++++ 1 file changed, 27 insertions(+) (limited to 'spec') diff --git a/spec/models/note_spec.rb b/spec/models/note_spec.rb index fe13c06b1e0..d90b54464cd 100644 --- a/spec/models/note_spec.rb +++ b/spec/models/note_spec.rb @@ -12,6 +12,33 @@ describe Note, models: true do describe 'validation' do it { is_expected.to validate_presence_of(:note) } it { is_expected.to validate_presence_of(:project) } + + context 'when note is comment on commit' do + before { allow(subject).to receive(:for_commit?).and_return(true) } + + it { is_expected.to validate_presence_of(:commit_id) } + it { is_expected.to_not validate_presence_of(:noteable_id) } + end + + context 'when note is not comment on commit' do + before { allow(subject).to receive(:for_commit?).and_return(false) } + + it { is_expected.to_not validate_presence_of(:commit_id) } + it { is_expected.to validate_presence_of(:noteable_id) } + end + + context 'when noteable and note project is different' do + subject do + build(:note, noteable: create(:issue), project: create(:project)) + end + + it { is_expected.to be_invalid } + end + + context 'when noteable and note project is the same one' do + subject { create(:note) } + it { is_expected.to be_valid } + end end describe "Commit notes" do -- cgit v1.2.3