From 601cd5b4c0395abadeda5cfaf3b269b12662f743 Mon Sep 17 00:00:00 2001 From: GitLab Bot Date: Wed, 15 Jun 2022 20:53:27 +0000 Subject: Add latest changes from gitlab-org/gitlab@15-0-stable-ee --- .../clusters_list/components/agent_token_spec.js | 5 ++++- spec/helpers/projects/cluster_agents_helper_spec.rb | 1 + spec/models/pool_repository_spec.rb | 20 ++++++++++++++++---- 3 files changed, 21 insertions(+), 5 deletions(-) (limited to 'spec') diff --git a/spec/frontend/clusters_list/components/agent_token_spec.js b/spec/frontend/clusters_list/components/agent_token_spec.js index 7f6ec2eb3a2..cdd94d33545 100644 --- a/spec/frontend/clusters_list/components/agent_token_spec.js +++ b/spec/frontend/clusters_list/components/agent_token_spec.js @@ -8,6 +8,7 @@ import ModalCopyButton from '~/vue_shared/components/modal_copy_button.vue'; const kasAddress = 'kas.example.com'; const agentToken = 'agent-token'; +const kasVersion = '15.0.0'; const modalId = INSTALL_AGENT_MODAL_ID; describe('InstallAgentModal', () => { @@ -21,6 +22,7 @@ describe('InstallAgentModal', () => { const createWrapper = () => { const provide = { kasAddress, + kasVersion, }; const propsData = { @@ -59,7 +61,7 @@ describe('InstallAgentModal', () => { it('renders a copy button', () => { expect(findCopyButton().props()).toMatchObject({ title: 'Copy command', - text: generateAgentRegistrationCommand(agentToken, kasAddress), + text: generateAgentRegistrationCommand(agentToken, kasAddress, kasVersion), modalId, }); }); @@ -71,6 +73,7 @@ describe('InstallAgentModal', () => { it('shows code block with agent installation command', () => { expect(findCodeBlock().props('code')).toContain(`--set config.token=${agentToken}`); expect(findCodeBlock().props('code')).toContain(`--set config.kasAddress=${kasAddress}`); + expect(findCodeBlock().props('code')).toContain(`--set image.tag=v${kasVersion}`); }); }); }); diff --git a/spec/helpers/projects/cluster_agents_helper_spec.rb b/spec/helpers/projects/cluster_agents_helper_spec.rb index 6849ec8b5ea..4045a7f6bf7 100644 --- a/spec/helpers/projects/cluster_agents_helper_spec.rb +++ b/spec/helpers/projects/cluster_agents_helper_spec.rb @@ -33,6 +33,7 @@ RSpec.describe Projects::ClusterAgentsHelper do empty_state_svg_path: kind_of(String), can_admin_vulnerability: "true", kas_address: Gitlab::Kas.external_url, + kas_version: Gitlab::Kas.version_info, can_admin_cluster: "false" }) } diff --git a/spec/models/pool_repository_spec.rb b/spec/models/pool_repository_spec.rb index 92b3e41cd18..447b7b2e0a2 100644 --- a/spec/models/pool_repository_spec.rb +++ b/spec/models/pool_repository_spec.rb @@ -24,23 +24,35 @@ RSpec.describe PoolRepository do end end - describe '#mark_obsolete_if_last' do + describe '#unlink_repository' do let(:pool) { create(:pool_repository, :ready) } + let(:repository_path) { File.join(TestEnv.repos_path, pool.source_project.repository.relative_path) } + let(:alternates_file) { File.join(repository_path, 'objects', 'info', 'alternates') } + + before do + pool.link_repository(pool.source_project.repository) + end context 'when the last member leaves' do it 'schedules pool removal' do expect(::ObjectPool::DestroyWorker).to receive(:perform_async).with(pool.id).and_call_original - pool.mark_obsolete_if_last(pool.source_project.repository) + pool.unlink_repository(pool.source_project.repository) + + expect(File).not_to exist(alternates_file) end end context 'when the second member leaves' do it 'does not schedule pool removal' do - create(:project, :repository, pool_repository: pool) + other_project = create(:project, :repository, pool_repository: pool) + pool.link_repository(other_project.repository) + expect(::ObjectPool::DestroyWorker).not_to receive(:perform_async).with(pool.id) - pool.mark_obsolete_if_last(pool.source_project.repository) + pool.unlink_repository(pool.source_project.repository) + + expect(File).not_to exist(alternates_file) end end end -- cgit v1.2.3