# frozen_string_literal: true require 'spec_helper' RSpec.describe Admin::ApplicationSettingsController, :do_not_mock_admin_mode_setting, feature_category: :shared do include StubENV include UsageDataHelpers let(:group) { create(:group) } let(:project) { create(:project, namespace: group) } let(:admin) { create(:admin) } let(:user) { create(:user) } before do stub_env('IN_MEMORY_APPLICATION_SETTINGS', 'false') end describe 'GET #integrations', feature_category: :integrations do before do sign_in(admin) end context 'when GitLab.com' do before do allow(::Gitlab).to receive(:com?) { true } end it 'returns 404' do get :integrations expect(response).to have_gitlab_http_status(:not_found) end end context 'when not GitLab.com' do before do allow(::Gitlab).to receive(:com?) { false } end it 'renders correct template' do get :integrations expect(response).to have_gitlab_http_status(:ok) expect(response).to render_template('admin/application_settings/integrations') end end end describe 'GET #usage_data with no access', feature_category: :service_ping do before do stub_usage_data_connections sign_in(user) end it 'returns 404' do get :usage_data, format: :html expect(response).to have_gitlab_http_status(:not_found) end end describe 'GET #usage_data', :with_license, feature_category: :service_ping do before do stub_usage_data_connections stub_database_flavor_check sign_in(admin) end context 'when there are NO recent ServicePing reports' do it 'return 404' do get :usage_data, format: :json expect(response).to have_gitlab_http_status(:not_found) end end context 'when there are recent ServicePing reports' do before do create(:raw_usage_data) end it 'does not trigger ServicePing generation' do expect(Gitlab::Usage::ServicePingReport).not_to receive(:for) get :usage_data, format: :json end it 'check cached data if present' do expect(Rails.cache).to receive(:fetch).with(Gitlab::Usage::ServicePingReport::CACHE_KEY).and_return({ test: 1 }) expect(::RawUsageData).not_to receive(:for_current_reporting_cycle) get :usage_data, format: :json end context 'if no cached data available' do before do allow(Rails.cache).to receive(:fetch).and_return(nil) end it 'returns latest RawUsageData' do expect(::RawUsageData).to receive_message_chain(:for_current_reporting_cycle, :first, :payload) get :usage_data, format: :json end end it 'returns HTML data' do get :usage_data, format: :html expect(response.body).to start_with(' 75) end it 'updates kroki_formats setting' do put :update, params: { application_setting: { kroki_formats_excalidraw: '1' } } expect(response).to redirect_to(general_admin_application_settings_path) expect(ApplicationSetting.current.kroki_formats_excalidraw).to eq(true) end it "updates default_branch_name setting" do put :update, params: { application_setting: { default_branch_name: "example_branch_name" } } expect(response).to redirect_to(general_admin_application_settings_path) expect(ApplicationSetting.current.default_branch_name).to eq("example_branch_name") end it 'updates valid_runner_registrars setting' do put :update, params: { application_setting: { valid_runner_registrars: ['project', ''] } } expect(response).to redirect_to(general_admin_application_settings_path) expect(ApplicationSetting.current.valid_runner_registrars).to eq(['project']) end it 'updates GitLab for Slack app settings' do settings = { slack_app_enabled: true, slack_app_id: 'slack_app_id', slack_app_secret: 'slack_app_secret', slack_app_signing_secret: 'slack_app_signing_secret', slack_app_verification_token: 'slack_app_verification_token' } put :update, params: { application_setting: settings } expect(response).to redirect_to(general_admin_application_settings_path) expect(ApplicationSetting.current).to have_attributes( slack_app_enabled: true, slack_app_id: 'slack_app_id', slack_app_secret: 'slack_app_secret', slack_app_signing_secret: 'slack_app_signing_secret', slack_app_verification_token: 'slack_app_verification_token' ) end context 'boolean attributes' do shared_examples_for 'updates boolean attribute' do |attribute| specify do existing_value = ApplicationSetting.current.public_send(attribute) new_value = !existing_value put :update, params: { application_setting: { attribute => new_value } } expect(response).to redirect_to(general_admin_application_settings_path) expect(ApplicationSetting.current.public_send(attribute)).to eq(new_value) end end it_behaves_like 'updates boolean attribute', :user_defaults_to_private_profile it_behaves_like 'updates boolean attribute', :can_create_group it_behaves_like 'updates boolean attribute', :can_create_organization it_behaves_like 'updates boolean attribute', :admin_mode it_behaves_like 'updates boolean attribute', :require_admin_approval_after_user_signup it_behaves_like 'updates boolean attribute', :remember_me_enabled end context "personal access token prefix settings" do let(:application_settings) { ApplicationSetting.current } shared_examples "accepts prefix setting" do |prefix| it "updates personal_access_token_prefix setting" do put :update, params: { application_setting: { personal_access_token_prefix: prefix } } expect(response).to redirect_to(general_admin_application_settings_path) expect(application_settings.reload.personal_access_token_prefix).to eq(prefix) end end shared_examples "rejects prefix setting" do |prefix| it "does not update personal_access_token_prefix setting" do put :update, params: { application_setting: { personal_access_token_prefix: prefix } } expect(response).not_to redirect_to(general_admin_application_settings_path) expect(application_settings.reload.personal_access_token_prefix).not_to eq(prefix) end end context "with valid prefix" do include_examples("accepts prefix setting", "a_prefix@") end context "with blank prefix" do include_examples("accepts prefix setting", "") end context "with too long prefix" do include_examples("rejects prefix setting", "a_prefix@" * 10) end context "with invalid characters prefix" do include_examples("rejects prefix setting", "a_préfixñ:") end end context 'external policy classification settings' do let(:settings) do { external_authorization_service_enabled: true, external_authorization_service_url: 'https://custom.service/', external_authorization_service_default_label: 'default', external_authorization_service_timeout: 3, external_auth_client_cert: File.read('spec/fixtures/passphrase_x509_certificate.crt'), external_auth_client_key: File.read('spec/fixtures/passphrase_x509_certificate_pk.key'), external_auth_client_key_pass: "5iveL!fe" } end it 'updates settings when the feature is available' do put :update, params: { application_setting: settings } settings.each do |attribute, value| expect(ApplicationSetting.current.public_send(attribute)).to eq(value) end end end describe 'verify panel actions' do Admin::ApplicationSettingsController::VALID_SETTING_PANELS.each do |valid_action| it_behaves_like 'renders correct panels' do let(:action) { valid_action } end end end describe 'EKS integration' do let(:application_setting) { ApplicationSetting.current } let(:settings_params) do { eks_integration_enabled: '1', eks_account_id: '123456789012', eks_access_key_id: 'dummy access key', eks_secret_access_key: 'dummy secret key' } end it 'updates EKS settings' do put :update, params: { application_setting: settings_params } expect(application_setting.eks_integration_enabled).to be_truthy expect(application_setting.eks_account_id).to eq '123456789012' expect(application_setting.eks_access_key_id).to eq 'dummy access key' expect(application_setting.eks_secret_access_key).to eq 'dummy secret key' end context 'secret access key is blank' do let(:settings_params) { { eks_secret_access_key: '' } } it 'does not update the secret key' do application_setting.update!(eks_secret_access_key: 'dummy secret key') put :update, params: { application_setting: settings_params } expect(application_setting.reload.eks_secret_access_key).to eq 'dummy secret key' end end end describe 'Terraform settings' do let(:application_setting) { ApplicationSetting.current } context 'max_terraform_state_size_bytes' do it 'updates the receive_max_input_size setting' do put :update, params: { application_setting: { max_terraform_state_size_bytes: '123' } } expect(response).to redirect_to(general_admin_application_settings_path) expect(application_setting.max_terraform_state_size_bytes).to eq(123) end end end context 'pipeline creation rate limiting' do let(:application_settings) { ApplicationSetting.current } it 'updates pipeline_limit_per_project_user_sha setting' do put :update, params: { application_setting: { pipeline_limit_per_project_user_sha: 25 } } expect(response).to redirect_to(general_admin_application_settings_path) expect(application_settings.reload.pipeline_limit_per_project_user_sha).to eq(25) end end context 'invitation flow enforcement setting' do let(:application_settings) { ApplicationSetting.current } it 'updates invitation_flow_enforcement setting' do put :update, params: { application_setting: { invitation_flow_enforcement: true } } expect(response).to redirect_to(general_admin_application_settings_path) expect(application_settings.reload.invitation_flow_enforcement).to eq(true) end end context 'maximum includes' do let(:application_settings) { ApplicationSetting.current } it 'updates ci_max_includes setting' do put :update, params: { application_setting: { ci_max_includes: 200 } } expect(response).to redirect_to(general_admin_application_settings_path) expect(application_settings.reload.ci_max_includes).to eq(200) end end end describe 'PUT #reset_registration_token', feature_category: :user_management do before do sign_in(admin) end subject { put :reset_registration_token } it 'resets runner registration token' do expect { subject }.to change { ApplicationSetting.current.runners_registration_token } end it 'redirects the user to admin runners page' do subject expect(response).to redirect_to(admin_runners_path) end end describe 'PUT #reset_error_tracking_access_token', feature_category: :error_tracking do before do sign_in(admin) end subject { put :reset_error_tracking_access_token } it 'resets error_tracking_access_token' do expect { subject }.to change { ApplicationSetting.current.error_tracking_access_token } end it 'redirects the user to application settings page' do subject expect(response).to redirect_to(general_admin_application_settings_path) end end describe 'GET #lets_encrypt_terms_of_service' do include LetsEncryptHelpers before do sign_in(admin) stub_lets_encrypt_client end subject { get :lets_encrypt_terms_of_service } it 'redirects the user to the terms of service page' do subject expect(response).to redirect_to("https://letsencrypt.org/documents/LE-SA-v1.2-November-15-2017.pdf") end end describe 'GET #slack_app_manifest_download', feature_category: :integrations do before do sign_in(admin) end subject { get :slack_app_manifest_download } it 'downloads the GitLab for Slack app manifest' do allow(Slack::Manifest).to receive(:to_h).and_return({ foo: 'bar' }) subject expect(response.body).to eq('{"foo":"bar"}') expect(response.headers['Content-Disposition']).to eq( 'attachment; filename="slack_manifest.json"; filename*=UTF-8\'\'slack_manifest.json' ) end end describe 'GET #slack_app_manifest_share', feature_category: :integrations do before do sign_in(admin) end subject { get :slack_app_manifest_share } it 'redirects the user to the Slack Manifest share URL' do allow(Slack::Manifest).to receive(:to_h).and_return({ foo: 'bar' }) subject expect(response).to redirect_to( "https://api.slack.com/apps?new_app=1&manifest_json=%7B%22foo%22%3A%22bar%22%7D" ) end end describe 'GET #metrics_and_profiling', feature_category: :service_ping do before do stub_usage_data_connections stub_database_flavor_check sign_in(admin) end it 'assigns service_ping_data if there are recent ServicePing reports in database' do create(:raw_usage_data) get :metrics_and_profiling, format: :html expect(assigns(:service_ping_data)).to be_present expect(response).to have_gitlab_http_status(:ok) end it 'assigns service_ping_data if there are recent ServicePing reports in cache', :use_clean_rails_memory_store_caching do create(:raw_usage_data) cached_data = { testKey: "testValue" } Rails.cache.write('usage_data', cached_data) get :metrics_and_profiling, format: :html expect(assigns(:service_ping_data)).to eq(cached_data) expect(response).to have_gitlab_http_status(:ok) end it 'does not assign service_ping_data value if there are NO recent ServicePing reports' do get :metrics_and_profiling, format: :html expect(assigns(:service_ping_data)).not_to be_present expect(response).to have_gitlab_http_status(:ok) end end end