# frozen_string_literal: true require 'spec_helper' describe Gitlab::Checks::DiffCheck do include_context 'change access checks context' describe '#validate!' do let(:owner) { create(:user) } let!(:lock) { create(:lfs_file_lock, user: owner, project: project, path: 'README') } before do allow(project.repository).to receive(:new_commits).and_return( project.repository.commits_between('be93687618e4b132087f430a4d8fc3a609c9b77c', '54fcc214b94e78d7a41a9a8fe6d87a5e59500e51') ) end context 'with LFS not enabled' do before do allow(project).to receive(:lfs_enabled?).and_return(false) end it 'does not invoke :lfs_file_locks_validation' do expect(subject).not_to receive(:lfs_file_locks_validation) subject.validate! end end context 'with LFS enabled' do before do allow(project).to receive(:lfs_enabled?).and_return(true) end context 'when change is sent by a different user' do it 'raises an error if the user is not allowed to update the file' do expect { subject.validate! }.to raise_error(Gitlab::GitAccess::ForbiddenError, "The path 'README' is locked in Git LFS by #{lock.user.name}") end end context 'when change is sent by the author of the lock' do let(:user) { owner } it "doesn't raise any error" do expect { subject.validate! }.not_to raise_error end end end context 'commit diff validations' do before do allow(subject).to receive(:validations_for_diff).and_return([lambda { |diff| return }]) expect_any_instance_of(Commit).to receive(:raw_deltas).and_call_original subject.validate! end context 'when request store is inactive' do it 'are run for every commit' do expect_any_instance_of(Commit).to receive(:raw_deltas).and_call_original subject.validate! end end context 'when request store is active', :request_store do it 'are cached for every commit' do expect_any_instance_of(Commit).not_to receive(:raw_deltas) subject.validate! end it 'are run for not cached commits' do allow(project.repository).to receive(:new_commits).and_return( project.repository.commits_between('be93687618e4b132087f430a4d8fc3a609c9b77c', 'a5391128b0ef5d21df5dd23d98557f4ef12fae20') ) change_access.instance_variable_set(:@commits, project.repository.new_commits) expect(project.repository.new_commits.first).not_to receive(:raw_deltas).and_call_original expect(project.repository.new_commits.last).to receive(:raw_deltas).and_call_original subject.validate! end end end end end