# frozen_string_literal: true require 'fast_spec_helper' require 'webmock/rspec' require 'timecop' require 'gitlab/danger/roulette' RSpec.describe Gitlab::Danger::Roulette do around do |example| Timecop.freeze(Time.utc(2020, 06, 22, 10)) { example.run } end let(:backend_maintainer) do { username: 'backend-maintainer', name: 'Backend maintainer', role: 'Backend engineer', projects: { 'gitlab' => 'maintainer backend' }, available: true, tz_offset_hours: 2.0 } end let(:frontend_reviewer) do { username: 'frontend-reviewer', name: 'Frontend reviewer', role: 'Frontend engineer', projects: { 'gitlab' => 'reviewer frontend' }, available: true, tz_offset_hours: 2.0 } end let(:frontend_maintainer) do { username: 'frontend-maintainer', name: 'Frontend maintainer', role: 'Frontend engineer', projects: { 'gitlab' => "maintainer frontend" }, available: true, tz_offset_hours: 2.0 } end let(:software_engineer_in_test) do { username: 'software-engineer-in-test', name: 'Software Engineer in Test', role: 'Software Engineer in Test, Create:Source Code', projects: { 'gitlab' => 'reviewer qa', 'gitlab-qa' => 'maintainer' }, available: true, tz_offset_hours: 2.0 } end let(:engineering_productivity_reviewer) do { username: 'eng-prod-reviewer', name: 'EP engineer', role: 'Engineering Productivity', projects: { 'gitlab' => 'reviewer backend' }, available: true, tz_offset_hours: 2.0 } end let(:teammate_json) do [ backend_maintainer, frontend_maintainer, frontend_reviewer, software_engineer_in_test, engineering_productivity_reviewer ].to_json end subject(:roulette) { Object.new.extend(described_class) } def matching_teammate(person) satisfy do |teammate| teammate.username == person[:username] && teammate.name == person[:name] && teammate.role == person[:role] && teammate.projects == person[:projects] end end def matching_spin(category, reviewer: { username: nil }, maintainer: { username: nil }, optional: nil) satisfy do |spin| bool = spin.category == category bool &&= spin.reviewer&.username == reviewer[:username] bool &&= if maintainer spin.maintainer&.username == maintainer[:username] else spin.maintainer.nil? end bool && spin.optional_role == optional end end describe '#spin' do let!(:project) { 'gitlab' } let!(:branch_name) { 'a-branch' } let!(:mr_labels) { ['backend', 'devops::create'] } let!(:author) { Gitlab::Danger::Teammate.new('username' => 'filipa') } let(:timezone_experiment) { false } let(:spins) do # Stub the request at the latest time so that we can modify the raw data, e.g. available fields. WebMock .stub_request(:get, described_class::ROULETTE_DATA_URL) .to_return(body: teammate_json) subject.spin(project, categories, branch_name, timezone_experiment: timezone_experiment) end before do allow(subject).to receive_message_chain(:gitlab, :mr_author).and_return(author.username) allow(subject).to receive_message_chain(:gitlab, :mr_labels).and_return(mr_labels) end context 'when timezone_experiment == false' do context 'when change contains backend category' do let(:categories) { [:backend] } it 'assigns backend reviewer and maintainer' do expect(spins).to contain_exactly(matching_spin(:backend, reviewer: engineering_productivity_reviewer, maintainer: backend_maintainer)) end context 'when teammate is not available' do before do backend_maintainer[:available] = false end it 'assigns backend reviewer and no maintainer' do expect(spins).to contain_exactly(matching_spin(:backend, reviewer: engineering_productivity_reviewer, maintainer: nil)) end end end context 'when change contains frontend category' do let(:categories) { [:frontend] } it 'assigns frontend reviewer and maintainer' do expect(spins).to contain_exactly(matching_spin(:frontend, reviewer: frontend_reviewer, maintainer: frontend_maintainer)) end end context 'when change contains QA category' do let(:categories) { [:qa] } it 'assigns QA reviewer' do expect(spins).to contain_exactly(matching_spin(:qa, reviewer: software_engineer_in_test)) end end context 'when change contains Engineering Productivity category' do let(:categories) { [:engineering_productivity] } it 'assigns Engineering Productivity reviewer and fallback to backend maintainer' do expect(spins).to contain_exactly(matching_spin(:engineering_productivity, reviewer: engineering_productivity_reviewer, maintainer: backend_maintainer)) end end context 'when change contains test category' do let(:categories) { [:test] } it 'assigns corresponding SET' do expect(spins).to contain_exactly(matching_spin(:test, reviewer: software_engineer_in_test)) end end end context 'when timezone_experiment == true' do let(:timezone_experiment) { true } context 'when change contains backend category' do let(:categories) { [:backend] } it 'assigns backend reviewer and maintainer' do expect(spins).to contain_exactly(matching_spin(:backend, reviewer: engineering_productivity_reviewer, maintainer: backend_maintainer)) end context 'when teammate is not in a good timezone' do before do backend_maintainer[:tz_offset_hours] = 5.0 end it 'assigns backend reviewer and no maintainer' do expect(spins).to contain_exactly(matching_spin(:backend, reviewer: engineering_productivity_reviewer, maintainer: nil)) end end end context 'when change includes a category with timezone disabled' do let(:categories) { [:backend] } before do stub_const("#{described_class}::INCLUDE_TIMEZONE_FOR_CATEGORY", backend: false) end it 'assigns backend reviewer and maintainer' do expect(spins).to contain_exactly(matching_spin(:backend, reviewer: engineering_productivity_reviewer, maintainer: backend_maintainer)) end context 'when teammate is not in a good timezone' do before do backend_maintainer[:tz_offset_hours] = 5.0 end it 'assigns backend reviewer and maintainer' do expect(spins).to contain_exactly(matching_spin(:backend, reviewer: engineering_productivity_reviewer, maintainer: backend_maintainer)) end end end end end describe '#team' do subject(:team) { roulette.team } context 'HTTP failure' do before do WebMock .stub_request(:get, described_class::ROULETTE_DATA_URL) .to_return(status: 404) end it 'raises a pretty error' do expect { team }.to raise_error(/Failed to read/) end end context 'JSON failure' do before do WebMock .stub_request(:get, described_class::ROULETTE_DATA_URL) .to_return(body: 'INVALID JSON') end it 'raises a pretty error' do expect { team }.to raise_error(/Failed to parse/) end end context 'success' do before do WebMock .stub_request(:get, described_class::ROULETTE_DATA_URL) .to_return(body: teammate_json) end it 'returns an array of teammates' do expected_teammates = [ matching_teammate(backend_maintainer), matching_teammate(frontend_reviewer), matching_teammate(frontend_maintainer), matching_teammate(software_engineer_in_test), matching_teammate(engineering_productivity_reviewer) ] is_expected.to contain_exactly(*expected_teammates) end it 'memoizes the result' do expect(team.object_id).to eq(roulette.team.object_id) end end end describe '#project_team' do subject { roulette.project_team('gitlab-qa') } before do WebMock .stub_request(:get, described_class::ROULETTE_DATA_URL) .to_return(body: teammate_json) end it 'filters team by project_name' do is_expected.to contain_exactly(matching_teammate(software_engineer_in_test)) end end describe '#spin_for_person' do let(:person_tz_offset_hours) { 0.0 } let(:person1) do Gitlab::Danger::Teammate.new( 'username' => 'rymai', 'available' => true, 'tz_offset_hours' => person_tz_offset_hours ) end let(:person2) do Gitlab::Danger::Teammate.new( 'username' => 'godfat', 'available' => true, 'tz_offset_hours' => person_tz_offset_hours) end let(:author) do Gitlab::Danger::Teammate.new( 'username' => 'filipa', 'available' => true, 'tz_offset_hours' => 0.0) end let(:unavailable) do Gitlab::Danger::Teammate.new( 'username' => 'jacopo-beschi', 'available' => false, 'tz_offset_hours' => 0.0) end before do allow(subject).to receive_message_chain(:gitlab, :mr_author).and_return(author.username) end (-4..4).each do |utc_offset| context "when local hour for person is #{10 + utc_offset} (offset: #{utc_offset})" do let(:person_tz_offset_hours) { utc_offset } [false, true].each do |timezone_experiment| context "with timezone_experiment == #{timezone_experiment}" do it 'returns a random person' do persons = [person1, person2] selected = subject.spin_for_person(persons, random: Random.new, timezone_experiment: timezone_experiment) expect(selected.username).to be_in(persons.map(&:username)) end end end end end ((-12..-5).to_a + (5..12).to_a).each do |utc_offset| context "when local hour for person is #{10 + utc_offset} (offset: #{utc_offset})" do let(:person_tz_offset_hours) { utc_offset } [false, true].each do |timezone_experiment| context "with timezone_experiment == #{timezone_experiment}" do it 'returns a random person or nil' do persons = [person1, person2] selected = subject.spin_for_person(persons, random: Random.new, timezone_experiment: timezone_experiment) if timezone_experiment expect(selected).to be_nil else expect(selected.username).to be_in(persons.map(&:username)) end end end end end end it 'excludes unavailable persons' do expect(subject.spin_for_person([unavailable], random: Random.new)).to be_nil end it 'excludes mr.author' do expect(subject.spin_for_person([author], random: Random.new)).to be_nil end end end