require 'spec_helper' describe Gitlab::HTTP do include StubRequests context 'when allow_local_requests' do it 'sends the request to the correct URI' do stub_full_request('https://example.org:8080', ip_address: '8.8.8.8').to_return(status: 200) described_class.get('https://example.org:8080', allow_local_requests: false) expect(WebMock).to have_requested(:get, 'https://8.8.8.8:8080').once end end context 'when not allow_local_requests' do it 'sends the request to the correct URI' do stub_full_request('https://example.org:8080') described_class.get('https://example.org:8080', allow_local_requests: true) expect(WebMock).to have_requested(:get, 'https://8.8.8.9:8080').once end end describe 'allow_local_requests_from_web_hooks_and_services is' do before do WebMock.stub_request(:get, /.*/).to_return(status: 200, body: 'Success') end context 'disabled' do before do allow(Gitlab::CurrentSettings).to receive(:allow_local_requests_from_web_hooks_and_services?).and_return(false) end it 'deny requests to localhost' do expect { described_class.get('http://localhost:3003') }.to raise_error(Gitlab::HTTP::BlockedUrlError) end it 'deny requests to private network' do expect { described_class.get('http://192.168.1.2:3003') }.to raise_error(Gitlab::HTTP::BlockedUrlError) end context 'if allow_local_requests set to true' do it 'override the global value and allow requests to localhost or private network' do stub_full_request('http://localhost:3003') expect { described_class.get('http://localhost:3003', allow_local_requests: true) }.not_to raise_error end end end context 'enabled' do before do allow(Gitlab::CurrentSettings).to receive(:allow_local_requests_from_web_hooks_and_services?).and_return(true) end it 'allow requests to localhost' do stub_full_request('http://localhost:3003') expect { described_class.get('http://localhost:3003') }.not_to raise_error end it 'allow requests to private network' do expect { described_class.get('http://192.168.1.2:3003') }.not_to raise_error end context 'if allow_local_requests set to false' do it 'override the global value and ban requests to localhost or private network' do expect { described_class.get('http://localhost:3003', allow_local_requests: false) }.to raise_error(Gitlab::HTTP::BlockedUrlError) end end end end describe 'handle redirect loops' do before do stub_full_request("http://example.org", method: :any).to_raise(HTTParty::RedirectionTooDeep.new("Redirection Too Deep")) end it 'handles GET requests' do expect { described_class.get('http://example.org') }.to raise_error(Gitlab::HTTP::RedirectionTooDeep) end it 'handles POST requests' do expect { described_class.post('http://example.org') }.to raise_error(Gitlab::HTTP::RedirectionTooDeep) end it 'handles PUT requests' do expect { described_class.put('http://example.org') }.to raise_error(Gitlab::HTTP::RedirectionTooDeep) end it 'handles DELETE requests' do expect { described_class.delete('http://example.org') }.to raise_error(Gitlab::HTTP::RedirectionTooDeep) end it 'handles HEAD requests' do expect { described_class.head('http://example.org') }.to raise_error(Gitlab::HTTP::RedirectionTooDeep) end end end