# frozen_string_literal: true require 'spec_helper' RSpec.describe SystemNotes::CommitService, feature_category: :code_review_workflow do let_it_be(:group) { create(:group) } let_it_be(:project) { create(:project, :repository, group: group) } let_it_be(:author) { create(:user) } let(:commit_service) { described_class.new(noteable: noteable, project: project, author: author) } describe '#add_commits' do subject { commit_service.add_commits(new_commits, old_commits, oldrev) } let(:noteable) { create(:merge_request, source_project: project, target_project: project) } let(:new_commits) { create_commits(10) } let(:old_commits) { [] } let(:oldrev) { nil } it_behaves_like 'a system note' do let(:commit_count) { new_commits.size } let(:action) { 'commit' } end describe 'note body' do let(:note_lines) { subject.note.split("\n").reject(&:blank?) } describe 'comparison diff link line' do it 'adds the comparison text' do expect(note_lines[2]).to match "[Compare with previous version]" end end context 'without existing commits' do it 'adds a message header' do expect(note_lines[0]).to eq "added #{new_commits.size} commits" end it 'adds a message for each commit' do decoded_note_content = HTMLEntities.new.decode(subject.note) new_commits.each do |commit| expect(decoded_note_content).to include("
  • #{commit.short_id} - #{commit.title}
  • ") end end context 'with HTML content' do let(:new_commits) { [double(title: '
    This is a test
    ', short_id: '12345678')] } it 'escapes HTML titles' do expect(note_lines[1]).to eq("") end end context 'with one commit exceeding the NEW_COMMIT_DISPLAY_LIMIT' do let(:new_commits) { create_commits(11) } let(:earlier_commit_summary_line) { note_lines[1] } it 'includes the truncated new commits summary' do expect(earlier_commit_summary_line).to start_with("