1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
|
# frozen_string_literal: true
require 'spec_helper'
describe Projects::Settings::OperationsController do
set(:user) { create(:user) }
before do
sign_in(user)
end
describe 'GET show' do
shared_examples 'user without read access' do |project_visibility|
let(:project) { create(:project, project_visibility) }
%w[guest reporter developer].each do |role|
before do
project.public_send("add_#{role}", user)
end
it 'returns 404' do
get :show, namespace_id: project.namespace, project_id: project
expect(response).to have_gitlab_http_status(:not_found)
end
end
end
shared_examples 'user with read access' do |project_visibility|
let(:project) { create(:project, project_visibility) }
before do
project.add_maintainer(user)
end
it 'renders ok' do
get :show, namespace_id: project.namespace, project_id: project
expect(response).to have_gitlab_http_status(200)
expect(response).to render_template(:show)
end
end
shared_examples 'user needs to login' do |project_visibility|
it 'redirects for private project' do
project = create(:project, project_visibility)
get :show, namespace_id: project.namespace, project_id: project
expect(response).to redirect_to(new_user_session_path)
end
end
context 'with a license' do
before do
stub_licensed_features(tracing: true)
end
context 'with maintainer role' do
it_behaves_like 'user with read access', :public
it_behaves_like 'user with read access', :private
it_behaves_like 'user with read access', :internal
end
context 'without maintainer role' do
it_behaves_like 'user without read access', :public
it_behaves_like 'user without read access', :private
it_behaves_like 'user without read access', :internal
end
context 'when user not logged in' do
before do
sign_out(user)
end
it_behaves_like 'user without read access', :public
it_behaves_like 'user needs to login', :private
it_behaves_like 'user needs to login', :internal
end
end
context 'without license' do
before do
stub_licensed_features(tracing: false)
end
it_behaves_like 'user without read access', :public
it_behaves_like 'user without read access', :private
it_behaves_like 'user without read access', :internal
end
end
describe 'PATCH update' do
let(:public_project) { create(:project, :public) }
let(:private_project) { create(:project, :private) }
let(:internal_project) { create(:project, :internal) }
before do
public_project.add_maintainer(user)
private_project.add_maintainer(user)
internal_project.add_maintainer(user)
end
shared_examples 'user without write access' do |project_visibility|
let(:project) { create(:project, project_visibility) }
%w[guest reporter developer].each do |role|
before do
project.public_send("add_#{role}", user)
end
it 'does not update tracing external_url' do
update_project(project, external_url: 'https://gitlab.com')
expect(project.tracing_setting).to be_nil
end
end
end
context 'with a license' do
before do
stub_licensed_features(tracing: true)
end
shared_examples 'user with write access' do |project_visibility, value_to_set, value_to_check|
let(:project) { create(:project, project_visibility) }
before do
project.add_maintainer(user)
end
it 'updates tracing external_url' do
update_project(project, external_url: value_to_set)
expect(project.tracing_setting.external_url).to eq(value_to_check)
end
end
context 'with maintainer role' do
it_behaves_like 'user with write access', :public, 'https://gitlab.com', 'https://gitlab.com'
it_behaves_like 'user with write access', :private, 'https://gitlab.com', 'https://gitlab.com'
it_behaves_like 'user with write access', :internal, 'https://gitlab.com', 'https://gitlab.com'
end
context 'with non maintainer roles' do
it_behaves_like 'user without write access', :public
it_behaves_like 'user without write access', :private
it_behaves_like 'user without write access', :internal
end
context 'with anonymous user' do
before do
sign_out(user)
end
it_behaves_like 'user without write access', :public
it_behaves_like 'user without write access', :private
it_behaves_like 'user without write access', :internal
end
context 'with existing tracing_setting' do
let(:project) { create(:project) }
before do
project.create_tracing_setting!(external_url: 'https://gitlab.com')
project.add_maintainer(user)
end
it 'unsets external_url with nil' do
update_project(project, external_url: nil)
expect(project.tracing_setting).to be_nil
end
it 'unsets external_url with empty string' do
update_project(project, external_url: '')
expect(project.tracing_setting).to be_nil
end
it 'fails validation with invalid url' do
expect do
update_project(project, external_url: "invalid")
end.not_to change(project.tracing_setting, :external_url)
end
it 'does not set external_url if not present in params' do
expect do
update_project(project, some_param: 'some_value')
end.not_to change(project.tracing_setting, :external_url)
end
end
context 'without existing tracing_setting' do
let(:project) { create(:project) }
before do
project.add_maintainer(user)
end
it 'fails validation with invalid url' do
update_project(project, external_url: "invalid")
expect(project.tracing_setting).to be_nil
end
it 'does not set external_url if not present in params' do
update_project(project, some_param: 'some_value')
expect(project.tracing_setting).to be_nil
end
end
end
context 'without a license' do
before do
stub_licensed_features(tracing: false)
end
it_behaves_like 'user without write access', :public
it_behaves_like 'user without write access', :private
it_behaves_like 'user without write access', :internal
end
private
def project_params(project, params = {})
{ namespace_id: project.namespace, project_id: project, tracing_settings: params }
end
def update_project(project, params)
patch :update, project_params(project, params)
project.reload
end
end
end
|
