Welcome to mirror list, hosted at ThFree Co, Russian Federation.

readlines_each.rb « performance « cop « rubocop - gitlab.com/gitlab-org/gitlab-foss.git - Unnamed repository; edit this file 'description' to name the repository.
summaryrefslogtreecommitdiff
blob: 7a3a15020db24977919a362cb7036919e1848ba8 (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
# frozen_string_literal: true

module RuboCop
  module Cop
    module Performance
      class ReadlinesEach < RuboCop::Cop::Base
        extend RuboCop::Cop::AutoCorrector

        MESSAGE = 'Avoid `IO.readlines.each`, since it reads contents into memory in full. ' \
          'Use `IO.each_line` or `IO.each` instead.'

        def_node_matcher :full_file_read_via_class?, <<~PATTERN
          (send
            (send (const nil? {:IO :File}) :readlines _) :each)
        PATTERN

        def_node_matcher :full_file_read_via_instance?, <<~PATTERN
          (... (... :readlines) :each)
        PATTERN

        def on_send(node)
          return unless full_file_read_via_class?(node) || full_file_read_via_instance?(node)

          add_offense(node.loc.selector, message: MESSAGE) do |corrector|
            corrector.replace(node.loc.expression, node.source.gsub('readlines.each', 'each_line'))
          end
        end
      end
    end
  end
end