1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
|
# frozen_string_literal: true
require 'spec_helper'
RSpec.describe Oauth::AuthorizationsController do
let(:user) { create(:user) }
let(:application_scopes) { 'api read_user' }
let!(:application) do
create(:oauth_application, scopes: application_scopes,
redirect_uri: 'http://example.com')
end
let(:params) do
{
response_type: "code",
client_id: application.uid,
redirect_uri: application.redirect_uri,
state: 'state'
}
end
before do
sign_in(user)
end
shared_examples 'OAuth Authorizations require confirmed user' do
context 'when the user is confirmed' do
context 'when there is already an access token for the application with a matching scope' do
before do
scopes = Doorkeeper::OAuth::Scopes.from_string('api')
allow(Doorkeeper.configuration).to receive(:scopes).and_return(scopes)
create(:oauth_access_token, application: application, resource_owner_id: user.id, scopes: scopes)
end
it 'authorizes the request and redirects' do
subject
expect(request.session['user_return_to']).to be_nil
expect(response).to have_gitlab_http_status(:found)
end
end
end
context 'when the user is unconfirmed' do
let(:user) { create(:user, :unconfirmed) }
it 'returns 200 and renders error view' do
subject
expect(response).to have_gitlab_http_status(:ok)
expect(response).to render_template('doorkeeper/authorizations/error')
end
end
end
describe 'GET #new' do
subject { get :new, params: params }
context 'when the user is confirmed' do
context 'when there is already an access token for the application with a matching scope' do
before do
scopes = Doorkeeper::OAuth::Scopes.from_string('api')
allow(Doorkeeper.configuration).to receive(:scopes).and_return(scopes)
create(:oauth_access_token, application: application, resource_owner_id: user.id, scopes: scopes)
end
it 'authorizes the request and shows the user a page that redirects' do
subject
expect(request.session['user_return_to']).to be_nil
expect(response).to have_gitlab_http_status(:ok)
expect(response).to render_template('doorkeeper/authorizations/redirect')
end
end
context 'without valid params' do
it 'returns 200 code and renders error view' do
get :new
expect(response).to have_gitlab_http_status(:ok)
expect(response).to render_template('doorkeeper/authorizations/error')
end
end
context 'with valid params' do
render_views
it 'returns 200 code and renders view' do
subject
expect(response).to have_gitlab_http_status(:ok)
expect(response).to render_template('doorkeeper/authorizations/new')
end
it 'deletes session.user_return_to and redirects when skip authorization' do
application.update!(trusted: true)
request.session['user_return_to'] = 'http://example.com'
subject
expect(request.session['user_return_to']).to be_nil
expect(response).to have_gitlab_http_status(:ok)
expect(response).to render_template('doorkeeper/authorizations/redirect')
end
context 'with gl_auth_type=login' do
let(:minimal_scope) { Gitlab::Auth::READ_USER_SCOPE.to_s }
before do
params[:gl_auth_type] = 'login'
end
shared_examples 'downgrades scopes' do
it 'downgrades the scopes' do
subject
pre_auth = controller.send(:pre_auth)
expect(pre_auth.scopes).to contain_exactly(minimal_scope)
expect(response).to have_gitlab_http_status(:ok)
expect(response).to render_template('doorkeeper/authorizations/new')
# See: config/locales/doorkeeper.en.yml
expect(response.body).to include("Read the authenticated user's personal information")
expect(response.body).not_to include("Access the authenticated user's API")
end
end
shared_examples 'adds read_user scope' do
it 'modifies the client.application.scopes' do
expect { subject }
.to change { application.reload.scopes }.to include(minimal_scope)
end
it 'does not remove pre-existing scopes' do
subject
expect(application.scopes).to include(*application_scopes.split(/ /))
end
end
context 'the application has all scopes' do
let(:application_scopes) { 'api read_api read_user' }
include_examples 'downgrades scopes'
end
context 'the application has api and read_user scopes' do
let(:application_scopes) { 'api read_user' }
include_examples 'downgrades scopes'
end
context 'the application has read_api and read_user scopes' do
let(:application_scopes) { 'read_api read_user' }
include_examples 'downgrades scopes'
end
context 'the application has only api scopes' do
let(:application_scopes) { 'api' }
include_examples 'downgrades scopes'
include_examples 'adds read_user scope'
end
context 'the application has only read_api scopes' do
let(:application_scopes) { 'read_api' }
include_examples 'downgrades scopes'
include_examples 'adds read_user scope'
end
context 'the application has scopes we do not handle' do
let(:application_scopes) { Gitlab::Auth::PROFILE_SCOPE.to_s }
before do
params[:scope] = application_scopes
end
it 'does not modify the scopes' do
subject
pre_auth = controller.send(:pre_auth)
expect(pre_auth.scopes).to contain_exactly(application_scopes)
expect(response).to have_gitlab_http_status(:ok)
expect(response).to render_template('doorkeeper/authorizations/new')
end
end
end
end
end
context 'when the user is not signed in' do
before do
sign_out(user)
end
it 'sets a lower session expiry and redirects to the sign in page' do
subject
expect(request.env['rack.session.options'][:expire_after]).to eq(
Settings.gitlab['unauthenticated_session_expire_delay']
)
expect(request.session['user_return_to']).to eq("/oauth/authorize?#{params.to_query}")
expect(response).to have_gitlab_http_status(:found)
expect(response).to redirect_to(new_user_session_path)
end
end
context 'when the user is admin' do
context 'when disable_admin_oauth_scopes is set' do
before do
stub_application_setting(disable_admin_oauth_scopes: true)
scopes = Doorkeeper::OAuth::Scopes.from_string('api')
allow(Doorkeeper.configuration).to receive(:scopes).and_return(scopes)
end
let(:user) { create(:user, :admin) }
it 'returns 200 and renders forbidden view' do
subject
expect(response).to have_gitlab_http_status(:ok)
expect(response).to render_template('doorkeeper/authorizations/forbidden')
end
end
context 'when disable_admin_oauth_scopes is set and the application is trusted' do
before do
stub_application_setting(disable_admin_oauth_scopes: true)
application.update!(trusted: true)
end
let(:application_scopes) { 'api' }
let(:user) { create(:user, :admin) }
it 'returns 200 and renders redirect view' do
subject
expect(response).to have_gitlab_http_status(:ok)
expect(response).to render_template('doorkeeper/authorizations/redirect')
end
end
context 'when disable_admin_oauth_scopes is disabled' do
before do
stub_application_setting(disable_admin_oauth_scopes: false)
end
let(:application_scopes) { 'api' }
let(:user) { create(:user, :admin) }
it 'returns 200 and renders new view' do
subject
expect(response).to have_gitlab_http_status(:ok)
expect(response).to render_template('doorkeeper/authorizations/new')
end
end
end
context 'when the user is not admin' do
context 'when disable_admin_oauth_scopes is enabled' do
before do
stub_application_setting(disable_admin_oauth_scopes: true)
end
it 'returns 200 and renders new view' do
subject
expect(response).to have_gitlab_http_status(:ok)
expect(response).to render_template('doorkeeper/authorizations/new')
end
end
end
end
describe 'POST #create' do
subject { post :create, params: params }
include_examples 'OAuth Authorizations require confirmed user'
end
describe 'DELETE #destroy' do
subject { delete :destroy, params: params }
include_examples 'OAuth Authorizations require confirmed user'
end
it 'includes Two-factor enforcement concern' do
expect(described_class.included_modules.include?(EnforcesTwoFactorAuthentication)).to eq(true)
end
end
|