1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
|
# frozen_string_literal: true
require 'spec_helper'
RSpec.describe Projects::TagsController do
let(:project) { create(:project, :public, :repository) }
let!(:release) { create(:release, project: project, tag: "v1.1.0") }
let!(:invalid_release) { create(:release, project: project, tag: 'does-not-exist') }
let(:user) { create(:user) }
describe 'GET index' do
subject { get :index, params: { namespace_id: project.namespace.to_param, project_id: project } }
it 'returns the tags for the page' do
subject
expect(assigns(:tags).map(&:name)).to include('v1.1.0', 'v1.0.0')
end
context 'default sort for tags' do
it 'sorts tags by recently updated' do
subject
expect(assigns(:sort)).to eq('updated_desc')
end
end
context 'when Gitaly is unavailable' do
where(:format) do
[:html, :atom]
end
with_them do
it 'returns 503 status code' do
expect_next_instance_of(TagsFinder) do |finder|
expect(finder).to receive(:execute).and_raise(Gitlab::Git::CommandError)
end
get :index, params: { namespace_id: project.namespace.to_param, project_id: project }, format: format
expect(assigns(:tags)).to eq([])
expect(assigns(:releases)).to eq([])
expect(response).to have_gitlab_http_status(:service_unavailable)
end
end
end
it 'returns releases matching those tags' do
subject
expect(assigns(:releases)).to include(release)
expect(assigns(:releases)).not_to include(invalid_release)
end
context '@tag_pipeline_status' do
context 'when no pipelines exist' do
it 'is empty' do
subject
expect(assigns(:tag_pipeline_statuses)).to be_empty
end
end
context 'when multiple tags exist' do
before do
create(:ci_pipeline,
project: project,
ref: 'v1.1.0',
sha: project.commit('v1.1.0').sha,
status: :running)
create(:ci_pipeline,
project: project,
ref: 'v1.0.0',
sha: project.commit('v1.0.0').sha,
status: :success)
end
it 'all relevant commit statuses are received' do
subject
expect(assigns(:tag_pipeline_statuses)['v1.1.0'].group).to eq("running")
expect(assigns(:tag_pipeline_statuses)['v1.0.0'].group).to eq("success")
end
end
context 'when a tag has multiple pipelines' do
before do
create(:ci_pipeline,
project: project,
ref: 'v1.0.0',
sha: project.commit('v1.0.0').sha,
status: :running,
created_at: 6.months.ago)
create(:ci_pipeline,
project: project,
ref: 'v1.0.0',
sha: project.commit('v1.0.0').sha,
status: :success,
created_at: 2.months.ago)
end
it 'chooses the latest to determine status' do
subject
expect(assigns(:tag_pipeline_statuses)['v1.0.0'].group).to eq("success")
end
end
end
end
describe 'GET show' do
before do
get :show, params: { namespace_id: project.namespace.to_param, project_id: project, id: id }
end
context "valid tag" do
let(:id) { 'v1.0.0' }
it { is_expected.to respond_with(:success) }
end
context "invalid tag" do
let(:id) { 'latest' }
it { is_expected.to respond_with(:not_found) }
end
end
describe 'POST #create' do
before do
project.add_developer(user)
sign_in(user)
end
let(:release_description) { nil }
subject(:request) do
post(:create, params: {
namespace_id: project.namespace.to_param,
project_id: project,
tag_name: '1.0',
ref: 'master',
release_description: release_description
})
end
it 'creates tag' do
subject
expect(response).to have_gitlab_http_status(:found)
expect(project.repository.find_tag('1.0')).to be_present
end
# TODO: remove this with the release creation moved to it's own form https://gitlab.com/gitlab-org/gitlab/-/issues/214245
context 'when release description is set' do
let(:release_description) { 'some release description' }
it 'creates tag and release' do
subject
expect(response).to have_gitlab_http_status(:found)
expect(project.repository.find_tag('1.0')).to be_present
release = project.releases.find_by_tag!('1.0')
expect(release).to be_present
expect(release.description).to eq(release_description)
end
it 'passes the last pipeline for evidence creation', :sidekiq_inline do
sha = project.repository.commit('master').sha
create(:ci_empty_pipeline, sha: sha, project: project) # old pipeline
pipeline = create(:ci_empty_pipeline, sha: sha, project: project)
# simulating pipeline creation by new tag
expect_any_instance_of(Repository).to receive(:add_tag).and_wrap_original do |m, *args|
create(:ci_empty_pipeline, sha: sha, project: project)
m.call(*args)
end
expect_next_instance_of(Releases::CreateEvidenceService, anything, pipeline: pipeline) do |service|
expect(service).to receive(:execute).and_call_original
end
subject
aggregate_failures do
expect(response).to have_gitlab_http_status(:found)
release = project.releases.find_by_tag('1.0')
expect(release).to be_present
expect(release&.description).to eq(release_description)
end
end
end
end
describe 'DELETE #destroy' do
let(:tag) { project.repository.add_tag(user, 'fake-tag', 'master') }
let(:request) do
delete(:destroy, params: { id: tag.name, namespace_id: project.namespace.to_param, project_id: project })
end
before do
project.add_developer(user)
sign_in(user)
request
end
it 'deletes tag and redirects to tags path' do
expect(project.repository.find_tag(tag.name)).not_to be_present
expect(controller).to set_flash[:notice].to(/Tag was removed/)
expect(response).to redirect_to(project_tags_path(project))
end
end
end
|
