1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
|
# frozen_string_literal: true
require 'spec_helper'
describe Projects::WikiPagesController do
set(:project) { create(:project, :public, :repository) }
let(:user) { project.owner }
let(:project_wiki) { ProjectWiki.new(project, user) }
let(:wiki) { project_wiki.wiki }
let(:wiki_title) { 'page-title-test' }
let(:parent_ids) { { namespace_id: project.namespace.path, project_id: project.name } }
let(:redirect_destination) { Rails.application.routes.recognize_path(response.redirect_url) }
before do
create_page(wiki_title, 'hello world')
sign_in(user)
end
after do
destroy_page(wiki_title)
end
def helper
Helper.instance
end
class Helper
include Singleton
include ActionView::Helpers::UrlHelper
end
describe 'GET #new' do
subject { get :new, params: parent_ids }
it 'redirects to #show and appends a `random_title` param' do
subject
expect(response).to have_http_status(302)
expect(redirect_destination)
.to include(parent_ids.merge(controller: 'projects/wiki_pages', action: 'show'))
expect(response.redirect_url).to match(/\?random_title=true\Z/)
end
end
describe 'GET #show' do
render_views
let(:requested_wiki_page) { wiki_title }
let(:random_title) { nil }
subject do
get :show, params: {
namespace_id: project.namespace,
project_id: project,
id: requested_wiki_page,
random_title: random_title
}
end
context 'when the wiki repo cannot be created' do
before do
allow(controller).to receive(:load_wiki) { raise ProjectWiki::CouldNotCreateWikiError }
end
it 'redirects to the project path' do
headers = { 'Location' => a_string_ending_with(Gitlab::Routing.url_helpers.project_path(project)) }
subject
expect(response).to be_redirect
expect(response.header.to_hash).to include(headers)
end
end
context 'when the page exists' do
it 'limits the retrieved pages for the sidebar' do
expect(controller).to receive(:load_wiki).and_return(project_wiki)
# Sidebar entries
expect(project_wiki).to receive(:list_pages).with(limit: 15).and_call_original
subject
expect(response).to have_http_status(:ok)
expect(response.body).to include(wiki_title)
end
context 'when page content encoding is invalid' do
it 'sets flash error' do
allow(controller).to receive(:valid_encoding?).and_return(false)
subject
expect(response).to have_http_status(:ok)
expect(flash[:notice]).to eq 'The content of this page is not encoded in UTF-8. Edits can only be made via the Git repository.'
end
end
end
context 'when the page does not exist' do
let(:requested_wiki_page) { 'this-page-does-not-yet-exist' }
context 'the current user can create wiki pages' do
it { is_expected.to render_template('edit') }
it 'makes a call to see if the wiki is empty' do
expect(controller).to receive(:load_wiki).and_return(project_wiki)
expect(project_wiki).to receive(:list_pages).once.with(limit: anything).and_call_original
expect(project_wiki).to receive(:list_pages).with(limit: 1).and_call_original
subject
end
describe 'assigned title' do
shared_examples :wiki_page_with_correct_title do
it 'assigns the correct title' do
subject
expect(assigns(:page)).to have_attributes(title: assigned_title)
end
end
context 'random_title is absent' do
let(:random_title) { nil }
it_behaves_like :wiki_page_with_correct_title do
let(:assigned_title) { WikiPage.unhyphenize(requested_wiki_page) }
end
end
context 'random_title is present' do
let(:random_title) { true }
it_behaves_like :wiki_page_with_correct_title do
let(:assigned_title) { be_empty }
end
end
end
end
context 'the current user cannot create wiki pages' do
before do
forbid_controller_ability! :create_wiki
end
it { is_expected.to render_template('missing_page') }
end
end
context 'when page is a file' do
include WikiHelpers
let(:path) { upload_file_to_wiki(project, user, file_name) }
before do
get :show, params: { namespace_id: project.namespace, project_id: project, id: path }
end
context 'when file is an image' do
let(:file_name) { 'dk.png' }
it 'delivers the image' do
expect(response.headers['Content-Disposition']).to match(/^inline/)
expect(response.headers[Gitlab::Workhorse::DETECT_HEADER]).to eq "true"
end
context 'when file is a svg' do
let(:file_name) { 'unsanitized.svg' }
it 'delivers the image' do
expect(response.headers['Content-Disposition']).to match(/^inline/)
expect(response.headers[Gitlab::Workhorse::DETECT_HEADER]).to eq "true"
end
end
end
context 'when file is a pdf' do
let(:file_name) { 'git-cheat-sheet.pdf' }
it 'sets the content type to sets the content response headers' do
expect(response.headers['Content-Disposition']).to match(/^inline/)
expect(response.headers[Gitlab::Workhorse::DETECT_HEADER]).to eq "true"
end
end
end
end
describe 'POST #preview_markdown' do
let(:page_id) { 'page/path' }
let(:markdown_text) { '*Markdown* text' }
let(:wiki_page) { create(:wiki_page, wiki: project_wiki, attrs: { title: wiki_title }) }
let(:processed_md) { json_response.fetch('body') }
let(:preview_params) do
{ namespace_id: project.namespace, project_id: project, id: wiki_page.slug, text: markdown_text }
end
before do
post :preview_markdown, params: preview_params
end
it 'renders json in a correct format' do
expect(response).to have_http_status(:ok)
expect(json_response).to include('body' => String, 'references' => Hash)
end
describe 'double brackets within backticks' do
let(:markdown_text) do
<<-HEREDOC
`[[do_not_linkify]]`
```
[[also_do_not_linkify]]
```
HEREDOC
end
it "does not linkify double brackets inside code blocks as expected" do
expect(processed_md).to include('[[do_not_linkify]]', '[[also_do_not_linkify]]')
end
end
describe 'link re-writing' do
let(:links) do
[
{ text: 'regular link', path: 'regular' },
{ text: 'relative link 1', path: '../relative' },
{ text: 'relative link 2', path: './relative' },
{ text: 'relative link 3', path: './e/f/relative' },
{ text: 'spaced link', path: 'title with spaces' }
]
end
shared_examples :wiki_link_rewriter do
let(:markdown_text) { links.map { |text:, path:| "[#{text}](#{path})" }.join("\n") }
let(:expected_links) do
links.zip(paths).map do |(link, path)|
helper.link_to(link[:text], "#{project_wiki.wiki_page_path}/#{path}")
end
end
it 'processes the links correctly' do
expect(processed_md).to include(*expected_links)
end
end
context 'the current page has spaces in its title' do
let(:wiki_title) { 'page a/page b/page c/page d' }
it_behaves_like :wiki_link_rewriter do
let(:paths) do
['regular',
'page-a/page-b/relative',
'page-a/page-b/page-c/relative',
'page-a/page-b/page-c/e/f/relative',
'title%20with%20spaces']
end
end
end
context 'the current page has an unproblematic title' do
let(:wiki_title) { 'a/b/c/d' }
it_behaves_like :wiki_link_rewriter do
let(:paths) do
['regular', 'a/b/relative', 'a/b/c/relative', 'a/b/c/e/f/relative', 'title%20with%20spaces']
end
end
end
context "when there are hyphens in the page name" do
let(:wiki_title) { 'page-a/page-b/page-c/page-d' }
it_behaves_like :wiki_link_rewriter do
let(:paths) do
['regular',
'page-a/page-b/relative',
'page-a/page-b/page-c/relative',
'page-a/page-b/page-c/e/f/relative',
'title%20with%20spaces']
end
end
end
end
end
describe 'GET #edit' do
subject { get(:edit, params: { namespace_id: project.namespace, project_id: project, id: wiki_title }) }
context 'when page content encoding is invalid' do
it 'redirects to show' do
allow(controller).to receive(:valid_encoding?).and_return(false)
subject
expect(response).to redirect_to(project_wiki_path(project, project_wiki.list_pages.first))
end
end
context 'when page content encoding is valid' do
render_views
it 'shows the edit page' do
subject
expect(response).to have_http_status(:ok)
expect(response.body).to include('Edit Page')
end
end
end
describe 'PATCH #update' do
let(:new_title) { 'New title' }
let(:new_content) { 'New content' }
subject do
patch(:update,
params: {
namespace_id: project.namespace,
project_id: project,
id: wiki_title,
wiki_page: { title: new_title, content: new_content }
})
end
context 'when page content encoding is invalid' do
it 'redirects to show' do
allow(controller).to receive(:valid_encoding?).and_return(false)
subject
expect(response).to redirect_to(project_wiki_path(project, project_wiki.list_pages.first))
end
end
context 'when page content encoding is valid' do
render_views
it 'updates the page' do
subject
wiki_page = project_wiki.list_pages(load_content: true).first
expect(wiki_page.title).to eq new_title
expect(wiki_page.content).to eq new_content
end
end
end
describe 'GET #history' do
before do
allow(controller)
.to receive(:can?)
.with(any_args)
.and_call_original
# The :create_wiki permission is irrelevant to reading history.
expect(controller)
.not_to receive(:can?)
.with(anything, :create_wiki, any_args)
allow(controller)
.to receive(:can?)
.with(anything, :read_wiki, any_args)
.and_return(allow_read_wiki)
end
shared_examples 'fetching history' do |expected_status|
before do
get :history, params: { namespace_id: project.namespace, project_id: project, id: wiki_title }
end
it "returns status #{expected_status}" do
expect(response).to have_http_status(expected_status)
end
end
it_behaves_like 'fetching history', :ok do
let(:allow_read_wiki) { true }
it 'assigns @page_versions' do
expect(assigns(:page_versions)).to be_present
end
end
it_behaves_like 'fetching history', :not_found do
let(:allow_read_wiki) { false }
end
end
private
def create_page(name, content)
wiki.write_page(name, :markdown, content, commit_details(name))
end
def commit_details(name)
Gitlab::Git::Wiki::CommitDetails.new(user.id, user.username, user.name, user.email, "created page #{name}")
end
def destroy_page(title, dir = '')
page = wiki.page(title: title, dir: dir)
project_wiki.delete_page(page, "test commit")
end
end
|