1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
|
# frozen_string_literal: true
require 'spec_helper'
RSpec.describe Repositories::GitHttpController, feature_category: :source_code_management do
let_it_be(:project) { create(:project_with_design, :public, :repository) }
let_it_be(:personal_snippet) { create(:personal_snippet, :public, :repository) }
let_it_be(:project_snippet) { create(:project_snippet, :public, :repository, project: project) }
shared_examples 'handles unavailable Gitaly' do
let(:params) { super().merge(service: 'git-upload-pack') }
before do
request.headers.merge! auth_env(user.username, user.password, nil)
end
context 'when Gitaly is unavailable', :use_clean_rails_redis_caching do
it 'responds with a 503 message' do
expect(Gitlab::GitalyClient).to receive(:call).and_raise(GRPC::Unavailable)
get :info_refs, params: params
expect(response).to have_gitlab_http_status(:service_unavailable)
expect(response.body).to eq('The git server, Gitaly, is not available at this time. Please contact your administrator.')
end
end
end
shared_examples 'handles user activity' do
it 'updates the user activity' do
activity_project = container.is_a?(PersonalSnippet) ? nil : project
activity_service = instance_double(Users::ActivityService)
args = { author: user, project: activity_project, namespace: activity_project&.namespace }
expect(Users::ActivityService).to receive(:new).with(args).and_return(activity_service)
expect(activity_service).to receive(:execute)
get :info_refs, params: params
end
end
shared_examples 'handles logging git upload pack operation' do
before do
password = user.try(:password) || user.try(:token)
request.headers.merge! auth_env(user.username, password, nil)
end
context 'with git pull/fetch/clone action' do
let(:params) { super().merge(service: 'git-upload-pack') }
it_behaves_like 'handles user activity'
end
end
shared_examples 'handles logging git receive pack operation' do
let(:params) { super().merge(service: 'git-receive-pack') }
before do
request.headers.merge! auth_env(user.username, user.password, nil)
end
context 'with git push action when log_user_git_push_activity is enabled' do
it_behaves_like 'handles user activity'
end
context 'when log_user_git_push_activity is disabled' do
before do
stub_feature_flags(log_user_git_push_activity: false)
end
it 'does not log user activity' do
expect(controller).not_to receive(:log_user_activity)
get :info_refs, params: params
end
end
end
context 'when repository container is a project' do
it_behaves_like described_class do
let(:container) { project }
let(:user) { project.first_owner }
let(:access_checker_class) { Gitlab::GitAccess }
it_behaves_like 'handles unavailable Gitaly'
it_behaves_like 'handles logging git upload pack operation'
it_behaves_like 'handles logging git receive pack operation'
describe 'POST #git_upload_pack' do
before do
allow(controller).to receive(:verify_workhorse_api!).and_return(true)
end
def send_request
post :git_upload_pack, params: params
end
it 'updates project statistics sync for projects' do
stub_feature_flags(disable_git_http_fetch_writes: false)
expect { send_request }.to change {
Projects::DailyStatisticsFinder.new(container).total_fetch_count
}.from(0).to(1)
end
describe 'recording the onboarding progress', :sidekiq_inline do
let_it_be(:namespace) { project.namespace }
before do
Onboarding::Progress.onboard(namespace)
send_request
end
subject { Onboarding::Progress.completed?(namespace, :git_pull) }
it { is_expected.to be(true) }
end
context 'when disable_git_http_fetch_writes is enabled' do
before do
stub_feature_flags(disable_git_http_fetch_writes: true)
end
it 'does not increment statistics' do
expect(Projects::FetchStatisticsIncrementService).not_to receive(:new)
send_request
end
end
end
end
context 'when the user is a deploy token' do
it_behaves_like described_class do
let(:container) { project }
let(:user) { create(:deploy_token, :project, projects: [project]) }
let(:access_checker_class) { Gitlab::GitAccess }
it_behaves_like 'handles logging git upload pack operation'
end
end
end
context 'when repository container is a project wiki' do
it_behaves_like described_class do
let(:container) { create(:project_wiki, :empty_repo, project: project) }
let(:user) { project.first_owner }
let(:access_checker_class) { Gitlab::GitAccessWiki }
it_behaves_like 'handles logging git upload pack operation'
it_behaves_like 'handles logging git receive pack operation'
end
end
context 'when repository container is a personal snippet' do
it_behaves_like described_class do
let(:container) { personal_snippet }
let(:user) { personal_snippet.author }
let(:access_checker_class) { Gitlab::GitAccessSnippet }
it_behaves_like 'handles unavailable Gitaly'
it_behaves_like 'handles logging git upload pack operation'
it_behaves_like 'handles logging git receive pack operation'
end
end
context 'when repository container is a project snippet' do
it_behaves_like described_class do
let(:container) { project_snippet }
let(:user) { project_snippet.author }
let(:access_checker_class) { Gitlab::GitAccessSnippet }
it_behaves_like 'handles unavailable Gitaly'
it_behaves_like 'handles logging git upload pack operation'
it_behaves_like 'handles logging git receive pack operation'
end
end
context 'when repository container is a design_management_repository' do
let(:container) { project.design_management_repository }
let(:access_checker_class) { Gitlab::GitAccessDesign }
let(:repository_path) { "#{container.full_path}.git" }
let(:params) { { repository_path: repository_path, service: 'git-upload-pack' } }
describe 'GET #info_refs' do
it 'calls the right access checker class with the right object' do
allow(controller).to receive(:verify_workhorse_api!).and_return(true)
access_double = double
expect(access_checker_class).to receive(:new)
.with(nil, container, 'http', hash_including({ repository_path: repository_path }))
.and_return(access_double)
allow(access_double).to receive(:check).and_return(false)
get :info_refs, params: params
end
end
end
end
|
