spec/features/merge_request/user_comments_on_whitespace_hidden_diff_spec.rb


1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49

# frozen_string_literal: true

require 'spec_helper'

RSpec.describe 'User comments on a diff with whitespace changes', :js, feature_category: :code_review_workflow do
  include MergeRequestDiffHelpers

  let_it_be(:project) { create(:project, :repository) }
  let(:merge_request) do
    create(:merge_request_with_diffs, source_project: project, target_project: project,
      source_branch: 'changes-with-whitespace')
  end

  let(:user) { create(:user) }

  before do
    project.add_maintainer(user)
    sign_in(user)

    visit(diffs_project_merge_request_path(project, merge_request, view: 'parallel'))
  end

  context 'when hiding whitespace changes' do
    before do
      find('.js-show-diff-settings').click
      find('[data-testid="show-whitespace"]').click
      wait_for_requests
    end

    it 'allows commenting on line combinations that are not present in the real diff' do
      # Comment on line combination old: 19, new 20
      # This line combination does not exist when whitespace is shown
      click_diff_line(
        find_by_scrolling('div[data-path="files/ruby/popen.rb"] .left-side a[data-linenumber="19"]').find(:xpath,
          '../..'), 'left')

      page.within('.js-discussion-note-form') do
        fill_in(:note_note, with: 'Comment on diff with whitespace')
        click_button('Add comment now')
      end

      wait_for_requests

      page.within('.notes_holder') do
        expect(page).to have_content('Comment on diff with whitespace')
      end
    end
  end
end