1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
|
# frozen_string_literal: true
require 'spec_helper'
RSpec.describe MilestonesFinder do
let_it_be(:now) { Date.current }
let_it_be(:group) { create(:group) }
let_it_be(:project_1) { create(:project, namespace: group) }
let_it_be(:project_2) { create(:project, namespace: group) }
let_it_be(:milestone_2) { create(:milestone, group: group, start_date: now + 1.day, due_date: now + 2.days) }
let_it_be(:milestone_4) { create(:milestone, project: project_2, state: 'active', start_date: now + 4.days, due_date: now + 5.days) }
context 'without filters' do
let_it_be(:milestone_1) { create(:milestone, group: group, start_date: now - 1.day, due_date: now) }
let_it_be(:milestone_3) { create(:milestone, project: project_1, state: 'active', start_date: now + 2.days) }
let_it_be(:milestone_5) { create(:milestone, group: group, due_date: now - 2.days) }
it 'returns milestones for projects' do
result = described_class.new(project_ids: [project_1.id, project_2.id], state: 'all').execute
expect(result).to contain_exactly(milestone_3, milestone_4)
end
it 'returns milestones for groups' do
result = described_class.new(group_ids: group.id, state: 'all').execute
expect(result).to contain_exactly(milestone_5, milestone_1, milestone_2)
end
context 'milestones for groups and project' do
let(:extra_params) { {} }
let(:result) do
described_class.new({ project_ids: [project_1.id, project_2.id], group_ids: group.id, state: 'all' }.merge(extra_params)).execute
end
it 'returns milestones for groups and projects' do
expect(result).to contain_exactly(milestone_5, milestone_1, milestone_2, milestone_3, milestone_4)
end
it 'orders milestones by due date', :aggregate_failures do
expect(result.first).to eq(milestone_5)
expect(result.second).to eq(milestone_1)
expect(result.third).to eq(milestone_2)
end
context 'when grouping and sorting by expired_last' do
let(:extra_params) { { sort: :expired_last_due_date_asc } }
it 'current milestones are returned first, then milestones without due date followed by expired milestones, sorted by due date in ascending order' do
expect(result).to eq([milestone_1, milestone_2, milestone_4, milestone_3, milestone_5])
end
end
end
describe '#find_by' do
it 'finds a single milestone' do
finder = described_class.new(project_ids: [project_1.id], state: 'all')
expect(finder.find_by(iid: milestone_3.iid)).to eq(milestone_3)
end
end
end
context 'with filters' do
let_it_be(:milestone_1) do
create(
:milestone,
group: group,
state: 'closed',
title: 'one test',
start_date: now - 1.day,
due_date: now,
updated_at: now - 3.days
)
end
let_it_be(:milestone_3) do
create(
:milestone,
project: project_1,
state: 'closed',
description: 'three test',
start_date: now + 2.days,
due_date: now + 3.days,
updated_at: now - 5.days
)
end
let(:result) { described_class.new(params).execute }
let(:params) do
{
project_ids: [project_1.id, project_2.id],
group_ids: group.id,
state: 'all'
}
end
it 'filters by id' do
params[:ids] = [milestone_1.id, milestone_2.id]
expect(result).to contain_exactly(milestone_1, milestone_2)
end
it 'filters by id or title' do
params[:ids] = [milestone_2.id]
params[:title] = [milestone_1.title]
expect(result).to contain_exactly(milestone_1, milestone_2)
end
it 'filters by active state' do
params[:state] = 'active'
expect(result).to contain_exactly(milestone_2, milestone_4)
end
it 'filters by closed state' do
params[:state] = 'closed'
expect(result).to contain_exactly(milestone_1, milestone_3)
end
it 'filters by title' do
params[:title] = 'one test'
expect(result).to contain_exactly(milestone_1)
end
it 'filters by search_title' do
params[:search_title] = 'test'
expect(result).to contain_exactly(milestone_1)
end
it 'filters by search (title, description)' do
params[:search] = 'test'
expect(result).to contain_exactly(milestone_1, milestone_3)
end
context 'by timeframe' do
it 'returns milestones with start_date and due_date between timeframe' do
params.merge!(start_date: now - 1.day, end_date: now + 3.days)
expect(result).to contain_exactly(milestone_1, milestone_2, milestone_3)
end
it 'returns milestones which starts before the timeframe' do
milestone = create(:milestone, project: project_2, start_date: now - 5.days)
params.merge!(start_date: now - 3.days, end_date: now - 2.days)
expect(result).to contain_exactly(milestone)
end
it 'returns milestones which ends after the timeframe' do
milestone = create(:milestone, project: project_2, due_date: now + 6.days)
params.merge!(start_date: now + 6.days, end_date: now + 7.days)
expect(result).to contain_exactly(milestone)
end
end
context 'by updated_at' do
it 'returns milestones updated before a given date' do
params[:updated_before] = 4.days.ago.iso8601
expect(result).to contain_exactly(milestone_3)
end
it 'returns milestones updated after a given date' do
params[:updated_after] = 4.days.ago.iso8601
expect(result).to contain_exactly(milestone_1, milestone_2, milestone_4)
end
it 'returns milestones updated between the given dates' do
params.merge!(updated_after: 6.days.ago.iso8601, updated_before: 4.days.ago.iso8601)
expect(result).to contain_exactly(milestone_3)
end
end
context 'by iids' do
before do
params[:iids] = 1
end
it 'returns milestone for the given iids' do
expect(result).to contain_exactly(milestone_2, milestone_3, milestone_4)
end
context 'when include_ancestors is true' do
it 'ignores the iid filter' do
params[:include_ancestors] = true
expect(result).to contain_exactly(milestone_1, milestone_2, milestone_3, milestone_4)
end
end
end
end
end
|
