1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
|
# frozen_string_literal: true
require 'spec_helper'
RSpec.describe ReleasesFinder, feature_category: :release_orchestration do
let_it_be(:user) { create(:user) }
let_it_be(:group) { create :group }
let_it_be(:project) { create(:project, :repository, group: group) }
let(:params) { {} }
let(:args) { {} }
let(:repository) { project.repository }
let_it_be(:v1_0_0) { create(:release, project: project, tag: 'v1.0.0') }
let_it_be(:v1_1_0) { create(:release, project: project, tag: 'v1.1.0') }
shared_examples_for 'when the user is not authorized' do
it 'returns no releases' do
is_expected.to be_empty
end
end
shared_examples_for 'when a tag parameter is passed' do
let(:params) { { tag: 'v1.0.0' } }
it 'only returns the release with the matching tag' do
expect(subject).to eq([v1_0_0])
end
end
shared_examples_for 'when a release is tagless' do
# There shouldn't be tags in this state, but because some exist in production and cause page loading errors, this
# test exists. We can test empty string but not the nil value since there is a not null constraint at the database
# level.
it 'does not return the tagless release' do
empty_string_tag = create(:release, project: project, tag: 'v99.0.0')
empty_string_tag.update_column(:tag, '')
expect(subject).not_to include(empty_string_tag)
end
end
shared_examples_for 'preload' do
it 'preloads associations' do
expect(Release).to receive(:preloaded).once.and_call_original
subject
end
context 'when preload is false' do
let(:args) { { preload: false } }
it 'does not preload associations' do
expect(Release).not_to receive(:preloaded)
subject
end
end
end
describe 'when parent is a project' do
subject { described_class.new(project, user, params).execute(**args) }
it_behaves_like 'when the user is not authorized'
context 'when the user has guest privileges or higher' do
before do
project.add_guest(user)
v1_0_0.update!(released_at: 2.days.ago, created_at: 1.day.ago)
v1_1_0.update!(released_at: 1.day.ago, created_at: 2.days.ago)
end
it 'returns the releases' do
is_expected.to be_present
expect(subject.size).to eq(2)
expect(subject).to match_array([v1_1_0, v1_0_0])
end
context 'with sorting parameters' do
it 'sorted by released_at in descending order by default' do
is_expected.to eq([v1_1_0, v1_0_0])
end
context 'released_at in ascending order' do
let(:params) { { sort: 'asc' } }
it { is_expected.to eq([v1_0_0, v1_1_0]) }
end
context 'order by created_at in descending order' do
let(:params) { { order_by: 'created_at' } }
it { is_expected.to eq([v1_0_0, v1_1_0]) }
end
context 'order by created_at in ascending order' do
let(:params) { { order_by: 'created_at', sort: 'asc' } }
it { is_expected.to eq([v1_1_0, v1_0_0]) }
end
end
it_behaves_like 'preload'
it_behaves_like 'when a tag parameter is passed'
it_behaves_like 'when a release is tagless'
end
end
describe 'when parent is an array of projects' do
let_it_be(:project2) { create(:project, :repository, group: group) }
let_it_be(:v2_0_0) { create(:release, project: project2, tag: 'v2.0.0') }
let_it_be(:v2_1_0) { create(:release, project: project2, tag: 'v2.1.0') }
subject { described_class.new([project, project2], user, params).execute(**args) }
it_behaves_like 'when the user is not authorized'
context 'when the user has guest privileges or higher on one project' do
before do
project.add_guest(user)
end
it 'returns the releases of only the authorized project' do
is_expected.to be_present
expect(subject.size).to eq(2)
expect(subject).to match_array([v1_1_0, v1_0_0])
end
end
context 'when the user has guest privileges or higher on all projects' do
before do
project.add_guest(user)
project2.add_guest(user)
v1_0_0.update!(released_at: 4.days.ago, created_at: 1.day.ago)
v1_1_0.update!(released_at: 3.days.ago, created_at: 2.days.ago)
v2_0_0.update!(released_at: 2.days.ago, created_at: 3.days.ago)
v2_1_0.update!(released_at: 1.day.ago, created_at: 4.days.ago)
end
it 'returns the releases of all projects' do
is_expected.to be_present
expect(subject.size).to eq(4)
expect(subject).to match_array([v2_1_0, v2_0_0, v1_1_0, v1_0_0])
end
it_behaves_like 'preload'
it_behaves_like 'when a tag parameter is passed'
it_behaves_like 'when a release is tagless'
context 'with sorting parameters' do
it 'sorted by released_at in descending order by default' do
is_expected.to eq([v2_1_0, v2_0_0, v1_1_0, v1_0_0])
end
context 'released_at in ascending order' do
let(:params) { { sort: 'asc' } }
it { is_expected.to eq([v1_0_0, v1_1_0, v2_0_0, v2_1_0]) }
end
context 'order by created_at in descending order' do
let(:params) { { order_by: 'created_at' } }
it { is_expected.to eq([v1_0_0, v1_1_0, v2_0_0, v2_1_0]) }
end
context 'order by created_at in ascending order' do
let(:params) { { order_by: 'created_at', sort: 'asc' } }
it { is_expected.to eq([v2_1_0, v2_0_0, v1_1_0, v1_0_0]) }
end
end
end
end
describe 'latest releases' do
let_it_be(:project2) { create(:project, :repository, group: group) }
let_it_be(:v2_0_0) { create(:release, project: project2) }
let_it_be(:v2_1_0) { create(:release, project: project2) }
let(:params) { { latest: true } }
subject { described_class.new([project, project2], user, params).execute(**args) }
before do
v1_0_0.update!(released_at: 4.days.ago, created_at: 1.day.ago)
v1_1_0.update!(released_at: 3.days.ago, created_at: 2.days.ago)
v2_0_0.update!(released_at: 2.days.ago, created_at: 3.days.ago)
v2_1_0.update!(released_at: 1.day.ago, created_at: 4.days.ago)
end
it_behaves_like 'when the user is not authorized'
context 'when the user has guest privileges or higher on one project' do
before do
project.add_guest(user)
end
it 'returns the latest release of only the authorized project' do
is_expected.to eq([v1_1_0])
end
end
context 'when the user has guest privileges or higher on all projects' do
before do
project.add_guest(user)
project2.add_guest(user)
end
it 'returns the latest release by released date for each project' do
is_expected.to match_array([v1_1_0, v2_1_0])
end
context 'with order_by_for_latest: created' do
let(:params) { { latest: true, order_by_for_latest: 'created_at' } }
it 'returns the latest release by created date for each project' do
is_expected.to match_array([v1_0_0, v2_0_0])
end
end
context 'when one project does not have releases' do
it 'returns the latest release of only the project with releases' do
project.releases.delete_all
is_expected.to eq([v2_1_0])
end
end
context 'when all projects do not have releases' do
it 'returns empty response' do
project.releases.delete_all
project2.releases.delete_all
is_expected.to be_empty
end
end
it_behaves_like 'preload'
it_behaves_like 'when a release is tagless'
end
end
end
|
