1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
|
import { shallowMount } from '@vue/test-utils';
import { nextTick } from 'vue';
import { TEST_HOST } from 'helpers/test_constants';
import ReviewerAvatarLink from '~/sidebar/components/reviewers/reviewer_avatar_link.vue';
import UncollapsedReviewerList from '~/sidebar/components/reviewers/uncollapsed_reviewer_list.vue';
const userDataMock = ({ approved = false } = {}) => ({
id: 1,
name: 'Root',
state: 'active',
username: 'root',
webUrl: `${TEST_HOST}/root`,
avatarUrl: `${TEST_HOST}/avatar/root.png`,
mergeRequestInteraction: {
canMerge: true,
canUpdate: true,
reviewed: true,
approved,
},
});
describe('UncollapsedReviewerList component', () => {
let wrapper;
const findAllRerequestButtons = () => wrapper.findAll('[data-testid="re-request-button"]');
const findAllReviewerApprovalIcons = () => wrapper.findAll('[data-testid="approved"]');
const findAllReviewedNotApprovedIcons = () =>
wrapper.findAll('[data-testid="reviewed-not-approved"]');
const findAllReviewerAvatarLinks = () => wrapper.findAllComponents(ReviewerAvatarLink);
const hasApprovalIconAnimation = () =>
findAllReviewerApprovalIcons().at(0).classes('merge-request-approved-icon');
function createComponent(props = {}, glFeatures = {}) {
const propsData = {
users: [],
rootPath: TEST_HOST,
...props,
};
wrapper = shallowMount(UncollapsedReviewerList, {
propsData,
provide: {
glFeatures,
},
});
}
describe('single reviewer', () => {
const user = userDataMock();
beforeEach(() => {
createComponent({
users: [user],
});
});
it('only has one user', () => {
expect(findAllReviewerAvatarLinks()).toHaveLength(1);
});
it('shows one user with avatar, and author name', () => {
expect(wrapper.text()).toBe(user.name);
});
it('renders re-request loading icon', async () => {
await findAllRerequestButtons().at(0).vm.$emit('click');
expect(findAllRerequestButtons().at(0).props('loading')).toBe(true);
});
});
describe('multiple reviewers', () => {
const user = userDataMock();
const user2 = {
...user,
id: 2,
name: 'nonrooty-nonrootersen',
username: 'hello-world',
mergeRequestInteraction: {
...user.mergeRequestInteraction,
approved: true,
},
};
const user3 = {
...user,
id: 3,
name: 'lizabeth-wilderman',
username: 'lizabeth-wilderman',
mergeRequestInteraction: {
...user.mergeRequestInteraction,
approved: false,
reviewed: true,
},
};
beforeEach(() => {
createComponent({
users: [user, user2, user3],
});
});
it('has three users', () => {
expect(findAllReviewerAvatarLinks()).toHaveLength(3);
});
it('shows all users with avatar, and author name', () => {
expect(wrapper.text()).toContain(user.name);
expect(wrapper.text()).toContain(user2.name);
expect(wrapper.text()).toContain(user3.name);
});
it('renders approval icon', () => {
expect(findAllReviewerApprovalIcons()).toHaveLength(1);
});
it('shows that hello-world approved', () => {
const icon = findAllReviewerApprovalIcons().at(0);
expect(icon.attributes('title')).toBe('Approved by @hello-world');
});
it('shows that lizabeth-wilderman reviewed but did not approve', () => {
const icon = findAllReviewedNotApprovedIcons().at(1);
expect(icon.attributes('title')).toBe('Reviewed by @lizabeth-wilderman but not yet approved');
});
it('renders re-request loading icon', async () => {
await findAllRerequestButtons().at(1).vm.$emit('click');
const allRerequestButtons = findAllRerequestButtons();
expect(allRerequestButtons).toHaveLength(3);
expect(allRerequestButtons.at(1).props('loading')).toBe(true);
});
});
describe('when updating reviewers list', () => {
it('does not animate icon on initial page load', () => {
const user = userDataMock({ approved: true });
createComponent({ users: [user] });
expect(hasApprovalIconAnimation()).toBe(false);
});
it('does not animate icon when adding a new reviewer', async () => {
const user = userDataMock({ approved: true });
const anotherUser = { ...user, id: 2 };
createComponent({ users: [user] });
await wrapper.setProps({ users: [user, anotherUser] });
expect(
findAllReviewerApprovalIcons().wrappers.every((w) =>
w.classes('merge-request-approved-icon'),
),
).toBe(false);
});
it('removes animation CSS class after 1500ms', async () => {
const previousUserState = userDataMock({ approved: false });
const currentUserState = userDataMock({ approved: true });
createComponent({
users: [previousUserState],
});
await wrapper.setProps({
users: [currentUserState],
});
expect(hasApprovalIconAnimation()).toBe(true);
jest.advanceTimersByTime(1500);
await nextTick();
expect(findAllReviewerApprovalIcons().at(0).classes('merge-request-approved-icon')).toBe(
false,
);
});
describe('when reviewer was present in the list', () => {
it.each`
previousApprovalState | currentApprovalState | shouldAnimate
${false} | ${true} | ${true}
${true} | ${true} | ${false}
`(
'when approval state changes from $previousApprovalState to $currentApprovalState',
async ({ previousApprovalState, currentApprovalState, shouldAnimate }) => {
const previousUserState = userDataMock({ approved: previousApprovalState });
const currentUserState = userDataMock({ approved: currentApprovalState });
createComponent({
users: [previousUserState],
});
await wrapper.setProps({
users: [currentUserState],
});
expect(hasApprovalIconAnimation()).toBe(shouldAnimate);
},
);
});
});
});
|
