1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
|
# frozen_string_literal: true
require 'spec_helper'
RSpec.describe Resolvers::LabelsResolver do
include GraphqlHelpers
using RSpec::Parameterized::TableSyntax
let_it_be(:current_user) { create(:user) }
let_it_be(:group, reload: true) { create(:group, :private) }
let_it_be(:subgroup, reload: true) { create(:group, :private, parent: group) }
let_it_be(:sub_subgroup, reload: true) { create(:group, :private, parent: subgroup) }
let_it_be(:project, reload: true) { create(:project, :private, group: subgroup) }
let_it_be(:label1) { create(:label, project: project, name: 'project feature') }
let_it_be(:label2) { create(:label, project: project, name: 'new project feature') }
let_it_be(:group_label1) { create(:group_label, group: group, name: 'group feature') }
let_it_be(:group_label2) { create(:group_label, group: group, name: 'new group feature') }
let_it_be(:subgroup_label1) { create(:group_label, group: subgroup, name: 'subgroup feature') }
let_it_be(:subgroup_label2) { create(:group_label, group: subgroup, name: 'new subgroup feature') }
let_it_be(:sub_subgroup_label1) { create(:group_label, group: sub_subgroup, name: 'sub_subgroup feature') }
let_it_be(:sub_subgroup_label2) { create(:group_label, group: sub_subgroup, name: 'new sub_subgroup feature') }
specify do
expect(described_class).to have_nullable_graphql_type(Types::LabelType.connection_type)
end
describe '#resolve' do
context 'with unauthorized user' do
it 'returns no labels' do
expect_graphql_error_to_be_created(Gitlab::Graphql::Errors::ResourceNotAvailable) do
resolve_labels(project)
end
end
end
context 'with authorized user' do
it 'returns no labels' do
group.add_guest(current_user)
expect { resolve_labels(project) }.not_to raise_error
end
end
context 'without parent' do
it 'returns no labels' do
expect(resolve_labels(nil)).to be_empty
end
end
describe 'association preloading' do
let_it_be(:project) { create(:project, :private, group: sub_subgroup) }
let(:params) do
{
include_ancestor_groups: true
}
end
before do
group.add_developer(current_user)
# warmup
resolve_labels(project, params).to_a
end
it 'prevents N+1 queries' do
control = Gitlab::WithRequestStore.with_request_store do
ActiveRecord::QueryRecorder.new { resolve_labels(project, params).to_a }
end
another_project = create(:project, :private, group: subgroup)
another_subgroup = create(:group, :private, parent: group)
create(:label, project: another_project, name: 'another project feature')
create(:group_label, group: another_subgroup, name: 'another group feature')
expect do
Gitlab::WithRequestStore.with_request_store do
resolve_labels(project, params).to_a
end
end.not_to exceed_query_limit(control.count)
end
end
context 'with a parent project' do
before_all do
group.add_developer(current_user)
end
# the expected result is wrapped in a lambda to get around the phase restrictions of RSpec::Parameterized
where(:include_ancestor_groups, :search_term, :expected_labels) do
nil | nil | -> { [label1, label2, subgroup_label1, subgroup_label2] }
false | nil | -> { [label1, label2, subgroup_label1, subgroup_label2] }
true | nil | -> { [label1, label2, group_label1, group_label2, subgroup_label1, subgroup_label2] }
nil | 'new' | -> { [label2, subgroup_label2] }
false | 'new' | -> { [label2, subgroup_label2] }
true | 'new' | -> { [label2, group_label2, subgroup_label2] }
end
with_them do
let(:params) do
{
include_ancestor_groups: include_ancestor_groups,
search_term: search_term
}
end
subject { resolve_labels(project, params) }
specify { expect(subject).to match_array(instance_exec(&expected_labels)) }
end
end
end
def resolve_labels(parent, args = {}, context = { current_user: current_user })
resolve(described_class, obj: parent, args: args, ctx: context)
end
end
|