1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
|
# frozen_string_literal: true
require 'spec_helper'
RSpec.describe Resolvers::TimelogResolver, feature_category: :team_planning do
include GraphqlHelpers
let_it_be(:current_user) { create(:user) }
let_it_be(:group) { create(:group) }
let_it_be(:project) { create(:project, :empty_repo, :public, group: group) }
let_it_be(:issue) { create(:issue, project: project) }
let_it_be(:error_class) { Gitlab::Graphql::Errors::ArgumentError }
let(:timelogs) { resolve_timelogs(**args) }
specify do
expect(described_class).to have_non_null_graphql_type(::Types::TimelogType.connection_type)
end
shared_examples_for 'with a project' do
let_it_be(:merge_request) { create(:merge_request, source_project: project) }
let_it_be(:timelog1) { create(:issue_timelog, issue: issue, spent_at: 2.days.ago.beginning_of_day) }
let_it_be(:timelog2) { create(:issue_timelog, issue: issue, spent_at: 2.days.ago.end_of_day) }
let_it_be(:timelog3) { create(:merge_request_timelog, merge_request: merge_request, spent_at: 10.days.ago) }
let(:args) { { start_time: 6.days.ago, end_time: 2.days.ago.noon } }
it 'finds all timelogs within given dates' do
expect(timelogs).to contain_exactly(timelog1)
end
context 'when the project does not exist' do
let(:extra_args) { { project_id: "gid://gitlab/Project/#{non_existing_record_id}" } }
it 'returns an empty set' do
expect(timelogs).to be_empty
end
end
context 'when no dates specified' do
let(:args) { {} }
it 'finds all timelogs' do
expect(timelogs).to contain_exactly(timelog1, timelog2, timelog3)
end
end
context 'when only start_time present' do
let(:args) { { start_time: 2.days.ago.noon } }
it 'finds timelogs after the start_time' do
expect(timelogs).to contain_exactly(timelog2)
end
end
context 'when only end_time present' do
let(:args) { { end_time: 2.days.ago.noon } }
it 'finds timelogs before the end_time' do
expect(timelogs).to contain_exactly(timelog1, timelog3)
end
end
context 'when start_time and end_date are present' do
let(:args) { { start_time: 6.days.ago, end_date: 2.days.ago } }
it 'finds timelogs until the end of day of end_date' do
expect(timelogs).to contain_exactly(timelog1, timelog2)
end
end
context 'when start_date and end_time are present' do
let(:args) { { start_date: 6.days.ago, end_time: 2.days.ago.noon } }
it 'finds all timelogs within start_date and end_time' do
expect(timelogs).to contain_exactly(timelog1)
end
end
it 'return nothing when user has insufficient permissions' do
project2 = create(:project, :empty_repo, :private)
issue2 = create(:issue, project: project2)
create(:issue_timelog, issue: issue2, spent_at: 2.days.ago.beginning_of_day)
user = create(:user)
expect(resolve_timelogs(user: user, obj: project2, **args)).to be_empty
end
context 'when arguments are invalid' do
let_it_be(:error_class) { Gitlab::Graphql::Errors::ArgumentError }
context 'when start_time and start_date are present' do
let(:args) { { start_time: 6.days.ago, start_date: 6.days.ago } }
it 'generates an error' do
expect_graphql_error_to_be_created(error_class, /Provide either a start date or time, but not both/) do
timelogs
end
end
end
context 'when end_time and end_date are present' do
let(:args) { { end_time: 2.days.ago, end_date: 2.days.ago } }
it 'generates an error' do
expect_graphql_error_to_be_created(error_class, /Provide either an end date or time, but not both/) do
timelogs
end
end
end
context 'when start argument is after end argument' do
let(:args) { { start_time: 2.days.ago, end_time: 6.days.ago } }
it 'generates an error' do
expect_graphql_error_to_be_created(error_class, /Start argument must be before End argument/) do
timelogs
end
end
end
end
end
shared_examples 'with a group' do
let_it_be(:short_time_ago) { 5.days.ago.beginning_of_day }
let_it_be(:medium_time_ago) { 15.days.ago.beginning_of_day }
let_it_be(:issue) { create(:issue, project: project) }
let_it_be(:merge_request) { create(:merge_request, source_project: project) }
let_it_be(:timelog1) { create(:issue_timelog, issue: issue, spent_at: short_time_ago.beginning_of_day) }
let_it_be(:timelog2) { create(:issue_timelog, issue: issue, spent_at: short_time_ago.end_of_day) }
let_it_be(:timelog3) { create(:merge_request_timelog, merge_request: merge_request, spent_at: medium_time_ago) }
let(:args) { { start_time: short_time_ago, end_time: short_time_ago.noon } }
it 'finds all timelogs' do
timelogs = resolve_timelogs
expect(timelogs).to contain_exactly(timelog1, timelog2, timelog3)
end
it 'finds all timelogs within given dates' do
expect(timelogs).to contain_exactly(timelog1)
end
context 'when the group does not exist' do
let_it_be(:error_class) { Gitlab::Graphql::Errors::ResourceNotAvailable }
let(:extra_args) { { group_id: "gid://gitlab/Group/#{non_existing_record_id}" } }
it 'returns an error' do
expect_graphql_error_to_be_created(error_class,
"The resource that you are attempting to access does not exist or " \
"you don't have permission to perform this action") do
timelogs
end
end
end
context 'when only start_date is present' do
let(:args) { { start_date: short_time_ago } }
it 'finds timelogs until the end of day of end_date' do
expect(timelogs).to contain_exactly(timelog1, timelog2)
end
end
context 'when only end_date is present' do
let(:args) { { end_date: medium_time_ago } }
it 'finds timelogs until the end of day of end_date' do
expect(timelogs).to contain_exactly(timelog3)
end
end
context 'when start_time and end_date are present' do
let(:args) { { start_time: short_time_ago, end_date: short_time_ago } }
it 'finds timelogs until the end of day of end_date' do
expect(timelogs).to contain_exactly(timelog1, timelog2)
end
end
context 'when start_date and end_time are present' do
let(:args) { { start_date: short_time_ago, end_time: short_time_ago.noon } }
it 'finds all timelogs within start_date and end_time' do
expect(timelogs).to contain_exactly(timelog1)
end
end
context 'when arguments are invalid' do
context 'when start_time and start_date are present' do
let(:args) { { start_time: short_time_ago, start_date: short_time_ago } }
it 'generates an error' do
expect_graphql_error_to_be_created(error_class, /Provide either a start date or time, but not both/) do
timelogs
end
end
end
context 'when end_time and end_date are present' do
let(:args) { { end_time: short_time_ago, end_date: short_time_ago } }
it 'generates an error' do
expect_graphql_error_to_be_created(error_class, /Provide either an end date or time, but not both/) do
timelogs
end
end
end
context 'when start argument is after end argument' do
let(:args) { { start_time: short_time_ago, end_time: medium_time_ago } }
it 'generates an error' do
expect_graphql_error_to_be_created(error_class, /Start argument must be before End argument/) do
timelogs
end
end
end
end
end
shared_examples 'with a user' do
let_it_be(:short_time_ago) { 5.days.ago.beginning_of_day }
let_it_be(:medium_time_ago) { 15.days.ago.beginning_of_day }
let_it_be(:issue) { create(:issue, project: project) }
let_it_be(:merge_request) { create(:merge_request, source_project: project) }
let_it_be(:timelog1) { create(:issue_timelog, issue: issue, user: current_user) }
let_it_be(:timelog2) { create(:issue_timelog, issue: issue, user: create(:user)) }
let_it_be(:timelog3) { create(:merge_request_timelog, merge_request: merge_request, user: current_user) }
it 'blah' do
if user_found
expect(timelogs).to contain_exactly(timelog1, timelog3)
else
expect(timelogs).to be_empty
end
end
end
context 'on a project' do
let(:object) { project }
let(:extra_args) { {} }
it_behaves_like 'with a project'
end
context 'with a project filter' do
let(:object) { nil }
let(:extra_args) { { project_id: project.to_global_id } }
it_behaves_like 'with a project'
end
context 'on a group' do
let(:object) { group }
let(:extra_args) { {} }
it_behaves_like 'with a group'
end
context 'with a group filter' do
let(:object) { nil }
let(:extra_args) { { group_id: group.to_global_id } }
it_behaves_like 'with a group'
end
context 'on a user' do
let(:object) { current_user }
let(:extra_args) { {} }
let(:args) { {} }
let(:user_found) { true }
it_behaves_like 'with a user'
end
context 'with a user filter' do
let(:object) { nil }
let(:args) { {} }
context 'when the user has timelogs' do
let(:extra_args) { { username: current_user.username } }
let(:user_found) { true }
it_behaves_like 'with a user'
end
context 'when the user doest not have timelogs' do
let(:extra_args) { { username: 'not_existing_user' } }
let(:user_found) { false }
it_behaves_like 'with a user'
end
end
context 'when no object or arguments provided' do
let(:object) { nil }
let(:args) { {} }
let(:extra_args) { {} }
it 'generates an error' do
expect_graphql_error_to_be_created(error_class, /Provide at least one argument/) do
timelogs
end
end
end
context 'when the sort argument is provided' do
let_it_be(:timelog_a) do
create(
:issue_timelog, time_spent: 7200, spent_at: 1.hour.ago,
created_at: 1.hour.ago, updated_at: 1.hour.ago, user: current_user
)
end
let_it_be(:timelog_b) do
create(
:issue_timelog, time_spent: 5400, spent_at: 2.hours.ago,
created_at: 2.hours.ago, updated_at: 2.hours.ago, user: current_user
)
end
let_it_be(:timelog_c) do
create(
:issue_timelog, time_spent: 1800, spent_at: 30.minutes.ago,
created_at: 30.minutes.ago, updated_at: 30.minutes.ago, user: current_user
)
end
let_it_be(:timelog_d) do
create(
:issue_timelog, time_spent: 3600, spent_at: 1.day.ago,
created_at: 1.day.ago, updated_at: 1.day.ago, user: current_user
)
end
let(:object) { current_user }
let(:extra_args) { {} }
context 'when sort argument comes from TimelogSortEnum' do
let(:args) { { sort: 'TIME_SPENT_ASC' } }
it 'returns all the timelogs in the correct order' do
expect(timelogs.items).to eq([timelog_c, timelog_d, timelog_b, timelog_a])
end
end
context 'when sort argument comes from SortEnum' do
let(:args) { { sort: 'CREATED_ASC' } }
it 'returns all the timelogs in the correct order' do
expect(timelogs.items).to eq([timelog_d, timelog_b, timelog_a, timelog_c])
end
end
end
def resolve_timelogs(user: current_user, obj: object, **args)
context = { current_user: user }
resolve(described_class, obj: obj, args: args.merge(extra_args), ctx: context)
end
end
|