1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
|
# frozen_string_literal: true
require 'spec_helper'
RSpec.describe MergeRequestsHelper, feature_category: :code_review_workflow do
include Users::CalloutsHelper
include ApplicationHelper
include PageLayoutHelper
include ProjectsHelper
include ProjectForksHelper
include IconsHelper
let_it_be(:current_user) { create(:user) }
describe '#format_mr_branch_names' do
describe 'within the same project' do
let(:merge_request) { create(:merge_request) }
subject { format_mr_branch_names(merge_request) }
it { is_expected.to eq([merge_request.source_branch, merge_request.target_branch]) }
end
describe 'within different projects' do
let(:project) { create(:project) }
let(:forked_project) { fork_project(project) }
let(:merge_request) { create(:merge_request, source_project: forked_project, target_project: project) }
subject { format_mr_branch_names(merge_request) }
let(:source_title) { "#{forked_project.full_path}:#{merge_request.source_branch}" }
let(:target_title) { "#{project.full_path}:#{merge_request.target_branch}" }
it { is_expected.to eq([source_title, target_title]) }
end
end
describe '#diffs_tab_pane_data' do
subject { diffs_tab_pane_data(project, merge_request, {}) }
context 'for endpoint_diff_for_path' do
context 'when sub-group project namespace' do
let_it_be(:group) { create(:group, :public) }
let_it_be(:subgroup) { create(:group, :private, parent: group) }
let_it_be(:project) { create(:project, :private, group: subgroup) }
let_it_be(:merge_request) { create(:merge_request, source_project: project, target_project: project) }
it 'returns expected values' do
expect(
subject[:endpoint_diff_for_path]
).to include("#{project.full_path}/-/merge_requests/#{merge_request.iid}/diff_for_path.json")
end
end
end
end
describe '#merge_path_description' do
# Using let_it_be(:project) raises the following error, so we use need to use let(:project):
# ActiveRecord::InvalidForeignKey:
# PG::ForeignKeyViolation: ERROR: insert or update on table "fork_network_members" violates foreign key
# constraint "fk_rails_a40860a1ca"
# DETAIL: Key (fork_network_id)=(8) is not present in table "fork_networks".
let(:project) { create(:project) }
let(:forked_project) { fork_project(project) }
let(:merge_request_forked) { create(:merge_request, source_project: forked_project, target_project: project) }
let(:merge_request) { create(:merge_request, source_project: project, target_project: project) }
where(:case_name, :mr, :with_arrow, :result) do
[
['forked with arrow', ref(:merge_request_forked), true, lazy do
"Project:Branches: #{
mr.source_project_path}:#{mr.source_branch} → #{
mr.target_project.full_path}:#{mr.target_branch}"
end],
['forked default', ref(:merge_request_forked), false, lazy do
"Project:Branches: #{
mr.source_project_path}:#{mr.source_branch} to #{
mr.target_project.full_path}:#{mr.target_branch}"
end],
['with arrow', ref(:merge_request), true, lazy { "Branches: #{mr.source_branch} → #{mr.target_branch}" }],
['default', ref(:merge_request), false, lazy { "Branches: #{mr.source_branch} to #{mr.target_branch}" }]
]
end
with_them do
subject { merge_path_description(mr, with_arrow: with_arrow) }
it {
is_expected.to eq(result)
}
end
end
describe '#tab_link_for' do
let(:merge_request) { create(:merge_request, :simple) }
let(:options) { {} }
subject { tab_link_for(merge_request, :show, options) { 'Discussion' } }
describe 'supports the :force_link option' do
let(:options) { { force_link: true } }
it 'removes the data-toggle attributes' do
is_expected.not_to match(/data-toggle="tabvue"/)
end
end
end
describe '#user_merge_requests_counts' do
let(:user) do
double(
assigned_open_merge_requests_count: 1,
review_requested_open_merge_requests_count: 2
)
end
subject { helper.user_merge_requests_counts }
before do
allow(helper).to receive(:current_user).and_return(user)
end
it "returns assigned, review requested and total merge request counts" do
expect(subject).to eq(
assigned: user.assigned_open_merge_requests_count,
review_requested: user.review_requested_open_merge_requests_count,
total: user.assigned_open_merge_requests_count + user.review_requested_open_merge_requests_count
)
end
end
describe '#reviewers_label' do
let(:merge_request) { build_stubbed(:merge_request) }
let(:reviewer1) { build_stubbed(:user, name: 'Jane Doe') }
let(:reviewer2) { build_stubbed(:user, name: 'John Doe') }
before do
allow(merge_request).to receive(:reviewers).and_return(reviewers)
end
context 'when multiple reviewers exist' do
let(:reviewers) { [reviewer1, reviewer2] }
it 'returns reviewer label with reviewer names' do
expect(helper.reviewers_label(merge_request)).to eq("Reviewers: Jane Doe and John Doe")
end
it 'returns reviewer label only with include_value: false' do
expect(helper.reviewers_label(merge_request, include_value: false)).to eq("Reviewers")
end
context 'when the name contains a URL' do
let(:reviewers) { [build_stubbed(:user, name: 'www.gitlab.com')] }
it 'returns sanitized name' do
expect(helper.reviewers_label(merge_request)).to eq("Reviewer: www_gitlab_com")
end
end
end
context 'when one reviewer exists' do
let(:reviewers) { [reviewer1] }
it 'returns reviewer label with no names' do
expect(helper.reviewers_label(merge_request)).to eq("Reviewer: Jane Doe")
end
it 'returns reviewer label only with include_value: false' do
expect(helper.reviewers_label(merge_request, include_value: false)).to eq("Reviewer")
end
end
context 'when no reviewers exist' do
let(:reviewers) { [] }
it 'returns reviewer label with no names' do
expect(helper.reviewers_label(merge_request)).to eq("Reviewers: ")
end
it 'returns reviewer label only with include_value: false' do
expect(helper.reviewers_label(merge_request, include_value: false)).to eq("Reviewers")
end
end
end
describe '#merge_request_source_branch' do
let_it_be(:project) { create(:project) }
let(:forked_project) { fork_project(project) }
let(:merge_request_forked) { create(:merge_request, source_project: forked_project, target_project: project) }
let(:merge_request) { create(:merge_request, source_project: project, target_project: project) }
context 'when merge request is a fork' do
subject { merge_request_source_branch(merge_request_forked) }
it 'does show the fork icon' do
expect(subject).to match(/fork/)
end
end
context 'when merge request is not a fork' do
subject { merge_request_source_branch(merge_request) }
it 'does not show the fork icon' do
expect(subject).not_to match(/fork/)
end
end
end
describe '#tab_count_display' do
let(:merge_request) { create(:merge_request) }
context 'when merge request is preparing' do
before do
allow(merge_request).to receive(:preparing?).and_return(true)
end
it { expect(tab_count_display(merge_request, 0)).to eq('-') }
it { expect(tab_count_display(merge_request, '0')).to eq('-') }
end
context 'when merge request is prepared' do
it { expect(tab_count_display(merge_request, 10)).to eq(10) }
it { expect(tab_count_display(merge_request, '10')).to eq('10') }
end
end
end
|
