1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
|
# frozen_string_literal: true
require 'rspec'
require 'spec_helper'
require 'mime/types'
RSpec.describe Projects::Ml::ExperimentsHelper, feature_category: :mlops do
let_it_be(:project) { create(:project, :private) }
let_it_be(:experiment) { create(:ml_experiments, user_id: project.creator, project: project) }
let_it_be(:pipeline) { create(:ci_pipeline, project: project) }
let_it_be(:build) { create(:ci_build, pipeline: pipeline) }
let_it_be(:candidate0) do
create(:ml_candidates,
:with_artifact,
experiment: experiment,
user: project.creator,
project: project,
ci_build: build
).tap do |c|
c.params.build([{ name: 'param1', value: 'p1' }, { name: 'param2', value: 'p2' }])
c.metrics.create!(
[{ name: 'metric1', value: 0.1 }, { name: 'metric2', value: 0.2 }, { name: 'metric3', value: 0.3 }]
)
end
end
let_it_be(:candidate1) do
create(:ml_candidates, experiment: experiment, user: project.creator, name: 'candidate1',
project: project).tap do |c|
c.params.build([{ name: 'param2', value: 'p3' }, { name: 'param3', value: 'p4' }])
c.metrics.create!(name: 'metric3', value: 0.4)
end
end
let_it_be(:candidates) { [candidate0, candidate1] }
describe '#candidates_table_items' do
subject { Gitlab::Json.parse(helper.candidates_table_items(candidates, project.creator)) }
it 'creates the correct model for the table', :aggregate_failures do
expected_values = [
{ 'param1' => 'p1', 'param2' => 'p2', 'metric1' => '0.1000', 'metric2' => '0.2000', 'metric3' => '0.3000',
'artifact' => "/#{project.full_path}/-/packages/#{candidate0.artifact.id}",
'details' => "/#{project.full_path}/-/ml/candidates/#{candidate0.iid}",
'ci_job' => { 'path' => "/#{project.full_path}/-/jobs/#{build.id}", 'name' => 'test' },
'name' => candidate0.name,
'created_at' => candidate0.created_at.strftime('%Y-%m-%dT%H:%M:%S.%LZ'),
'user' => { 'username' => candidate0.user.username, 'path' => "/#{candidate0.user.username}" } },
{ 'param2' => 'p3', 'param3' => 'p4', 'metric3' => '0.4000',
'artifact' => nil, 'details' => "/#{project.full_path}/-/ml/candidates/#{candidate1.iid}",
'ci_job' => nil,
'name' => candidate1.name,
'created_at' => candidate1.created_at.strftime('%Y-%m-%dT%H:%M:%S.%LZ'),
'user' => { 'username' => candidate1.user.username, 'path' => "/#{candidate1.user.username}" } }
]
subject.sort_by! { |s| s[:name] }
expect(subject[0]).to eq(expected_values[0])
expect(subject[1]).to eq(expected_values[1])
end
context 'when candidate does not have user' do
let(:candidates) { [candidate0] }
before do
allow(candidate0).to receive(:user).and_return(nil)
end
it 'has the user property, but is nil' do
expect(subject[0]['user']).to be_nil
end
end
context 'when user is not allowed to read the project' do
before do
allow(Ability).to receive(:allowed?)
.with(project.creator, :read_build, build)
.and_return(false)
end
it 'does not include ci info' do
expect(subject[0]['ci_job']).to be_nil
end
end
end
describe '#unique_logged_names' do
context 'when for params' do
subject { Gitlab::Json.parse(helper.unique_logged_names(candidates, &:params)) }
it { is_expected.to match_array(%w[param1 param2 param3]) }
end
context 'when latest_metrics is passed' do
subject { Gitlab::Json.parse(helper.unique_logged_names(candidates, &:latest_metrics)) }
it { is_expected.to match_array(%w[metric1 metric2 metric3]) }
end
end
describe '#experiment_as_data' do
subject { Gitlab::Json.parse(helper.experiment_as_data(experiment)) }
it do
is_expected.to eq(
{ 'name' => experiment.name, 'path' => "/#{project.full_path}/-/ml/experiments/#{experiment.iid}" }
)
end
end
describe '#experiments_as_data' do
let(:experiments) { [experiment] }
subject { Gitlab::Json.parse(helper.experiments_as_data(project, experiments)) }
before do
allow(experiment).to receive(:candidate_count).and_return(2)
end
it 'generates the correct info' do
expected_info = {
"name" => experiment.name,
"path" => "/#{project.full_path}/-/ml/experiments/#{experiment.iid}",
"candidate_count" => 2
}
expect(subject[0]).to eq(expected_info)
end
end
describe '#page_info' do
def paginator(cursor = nil)
experiment.candidates.keyset_paginate(cursor: cursor, per_page: 1)
end
let_it_be(:first_page) { paginator }
let_it_be(:second_page) { paginator(first_page.cursor_for_next_page) }
let(:page) { nil }
subject { helper.page_info(page) }
context 'when is first page' do
let(:page) { first_page }
it 'generates the correct page_info' do
is_expected.to include({
has_next_page: true,
has_previous_page: false,
start_cursor: nil
})
end
end
context 'when is last page' do
let(:page) { second_page }
it 'generates the correct page_info' do
is_expected.to include({
has_next_page: false,
has_previous_page: true,
start_cursor: second_page.cursor_for_previous_page,
end_cursor: nil
})
end
end
end
describe '#formatted_page_info' do
it 'formats to json' do
expect(helper.formatted_page_info({ a: 1, b: 'c' })).to eq("{\"a\":1,\"b\":\"c\"}")
end
end
end
|