1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
|
# frozen_string_literal: true
require 'spec_helper'
RSpec.describe Gitlab::BitbucketImport::Importers::PullRequestImporter, :clean_gitlab_redis_cache, feature_category: :importers do
include AfterNextHelpers
let_it_be(:project) { create(:project, :repository) }
let_it_be(:bitbucket_user) { create(:user) }
let_it_be(:user_2) { create(:user) }
let_it_be(:user_3) { create(:user) }
let_it_be(:identity) { create(:identity, user: bitbucket_user, extern_uid: 'bitbucket_user', provider: :bitbucket) }
let_it_be(:identity_2) { create(:identity, user: user_2, extern_uid: 'user_2', provider: :bitbucket) }
let(:source_branch_sha) { project.repository.commit.sha }
let(:target_branch_sha) { project.repository.commit('refs/heads/master').sha }
let(:hash) do
{
author: 'bitbucket_user',
created_at: Date.today,
description: 'description',
iid: 11,
source_branch_name: 'source-branch-name',
source_branch_sha: source_branch_sha,
state: 'merged',
target_branch_name: 'destination-branch-name',
target_branch_sha: target_branch_sha,
title: 'title',
updated_at: Date.today,
reviewers: %w[user_2 user_3]
}
end
subject(:importer) { described_class.new(project, hash) }
describe '#execute' do
it 'calls MergeRequestCreator' do
expect(Gitlab::Import::MergeRequestCreator).to receive_message_chain(:new, :execute)
importer.execute
end
it 'creates a merge request with the correct attributes' do
expect { importer.execute }.to change { project.merge_requests.count }.from(0).to(1)
merge_request = project.merge_requests.first
expect(merge_request.iid).to eq(11)
expect(merge_request.author).to eq(bitbucket_user)
expect(merge_request.title).to eq('title')
expect(merge_request.merged?).to be_truthy
expect(merge_request.created_at).to eq(Date.today)
expect(merge_request.description).to eq('description')
expect(merge_request.source_project_id).to eq(project.id)
expect(merge_request.target_project_id).to eq(project.id)
expect(merge_request.source_branch).to eq('source-branch-name')
expect(merge_request.target_branch).to eq('destination-branch-name')
expect(merge_request.assignee_ids).to eq([bitbucket_user.id])
expect(merge_request.reviewer_ids).to eq([user_2.id])
expect(merge_request.merge_request_diffs.first.base_commit_sha).to eq(source_branch_sha)
expect(merge_request.merge_request_diffs.first.head_commit_sha).to eq(target_branch_sha)
end
context 'when the state is closed' do
it 'marks merge request as closed' do
described_class.new(project, hash.merge(state: 'closed')).execute
expect(project.merge_requests.first.closed?).to be_truthy
end
end
context 'when the state is opened' do
it 'marks merge request as opened' do
described_class.new(project, hash.merge(state: 'opened')).execute
expect(project.merge_requests.first.opened?).to be_truthy
end
end
context 'when the source and target projects are different' do
let(:importer) { described_class.new(project, hash.merge(source_and_target_project_different: true)) }
it 'skips the import' do
expect(Gitlab::BitbucketImport::Logger)
.to receive(:info)
.with(include(message: 'skipping because source and target projects are different', iid: anything))
expect { importer.execute }.not_to change { project.merge_requests.count }
end
end
context 'when the author does not have a bitbucket identity' do
before do
identity.update!(provider: :github)
end
it 'sets the author and assignee to the project creator and adds the author to the description' do
importer.execute
merge_request = project.merge_requests.first
expect(merge_request.author).to eq(project.creator)
expect(merge_request.assignee).to eq(project.creator)
expect(merge_request.description).to eq("*Created by: bitbucket_user*\n\ndescription")
end
end
context 'when none of the reviewers have an identity' do
before do
identity_2.destroy!
end
it 'does not set reviewer_ids' do
importer.execute
merge_request = project.merge_requests.first
expect(merge_request.reviewer_ids).to be_empty
end
end
describe 'head_commit_sha for merge request diff' do
let(:diff) { project.merge_requests.first.merge_request_diffs.first }
let(:min_length) { Commit::MIN_SHA_LENGTH }
context 'when the source commit hash from Bitbucket is found on the repo' do
it 'is set to the source commit hash' do
described_class.new(project, hash.merge(source_branch_sha: source_branch_sha)).execute
expect(diff.head_commit_sha).to eq(source_branch_sha)
end
end
context 'when the source commit hash is not found but the merge commit hash is found' do
it 'is set to the merge commit hash' do
attrs = { source_branch_sha: 'x' * min_length, merge_commit_sha: source_branch_sha }
described_class.new(project, hash.merge(attrs)).execute
expect(diff.head_commit_sha).to eq(source_branch_sha)
end
end
context 'when both the source commit and merge commit hash are not found' do
it 'is nil' do
attrs = { source_branch_sha: 'x' * min_length, merge_commit_sha: 'y' * min_length }
described_class.new(project, hash.merge(attrs)).execute
expect(diff.head_commit_sha).to be_nil
end
end
end
context 'when an error is raised' do
before do
allow(Gitlab::Import::MergeRequestCreator).to receive(:new).and_raise(StandardError)
end
it 'tracks the failure and does not fail' do
expect(Gitlab::Import::ImportFailureService).to receive(:track).once
importer.execute
end
end
it 'logs its progress' do
allow(Gitlab::Import::MergeRequestCreator).to receive_message_chain(:new, :execute)
expect(Gitlab::BitbucketImport::Logger)
.to receive(:info).with(include(message: 'starting', iid: anything)).and_call_original
expect(Gitlab::BitbucketImport::Logger)
.to receive(:info).with(include(message: 'finished', iid: anything)).and_call_original
importer.execute
end
it 'increments the merge requests counter' do
expect_next_instance_of(Gitlab::Import::Metrics) do |metrics|
expect(metrics).to receive_message_chain(:merge_requests_counter, :increment)
end
importer.execute
end
end
end
|
