1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
|
# frozen_string_literal: true
require 'spec_helper'
RSpec.describe Gitlab::Ci::Config::Entry::Artifacts do
let(:entry) { described_class.new(config) }
describe 'validation' do
context 'when entry config value is correct' do
let(:config) { { paths: %w[public/] } }
describe '#value' do
it 'returns artifacts configuration' do
expect(entry.value).to eq config
end
end
describe '#valid?' do
it 'is valid' do
expect(entry).to be_valid
end
end
context "when value includes 'reports' keyword" do
let(:config) { { paths: %w[public/], reports: { junit: 'junit.xml' } } }
it 'returns general artifact and report-type artifacts configuration' do
expect(entry.value).to eq config
end
end
context "when value includes 'expose_as' keyword" do
let(:config) { { paths: %w[results.txt], expose_as: "Test results" } }
it 'returns general artifact and report-type artifacts configuration' do
expect(entry.value).to eq config
end
end
context "when value includes 'public' keyword" do
let(:config) { { paths: %w[results.txt], public: false } }
it 'returns general artifact and report-type artifacts configuration' do
expect(entry.value).to eq config
end
end
end
context 'when entry value is not correct' do
describe '#errors' do
context 'when value of attribute is invalid' do
let(:config) { { name: 10 } }
it 'reports error' do
expect(entry.errors)
.to include 'artifacts name should be a string'
end
end
context 'when there is an unknown key present' do
let(:config) { { test: 100 } }
it 'reports error' do
expect(entry.errors)
.to include 'artifacts config contains unknown keys: test'
end
end
context "when 'reports' keyword is not hash" do
let(:config) { { paths: %w[public/], reports: 'junit.xml' } }
it 'reports error' do
expect(entry.errors)
.to include 'artifacts reports should be a hash'
end
end
context "when 'public' is not a boolean" do
let(:config) { { paths: %w[results.txt], public: 'false' } }
it 'reports error' do
expect(entry.errors)
.to include 'artifacts public should be a boolean value'
end
end
context "when 'expose_as' is not a string" do
let(:config) { { paths: %w[results.txt], expose_as: 1 } }
it 'reports error' do
expect(entry.errors)
.to include 'artifacts expose as should be a string'
end
end
context "when 'expose_as' is too long" do
let(:config) { { paths: %w[results.txt], expose_as: 'A' * 101 } }
it 'reports error' do
expect(entry.errors)
.to include 'artifacts expose as is too long (maximum is 100 characters)'
end
end
context "when 'expose_as' is an empty string" do
let(:config) { { paths: %w[results.txt], expose_as: '' } }
it 'reports error' do
expect(entry.errors)
.to include 'artifacts expose as ' + Gitlab::Ci::Config::Entry::Artifacts::EXPOSE_AS_ERROR_MESSAGE
end
end
context "when 'expose_as' contains invalid characters" do
let(:config) do
{ paths: %w[results.txt], expose_as: '<script>alert("xss");</script>' }
end
it 'reports error' do
expect(entry.errors)
.to include 'artifacts expose as ' + Gitlab::Ci::Config::Entry::Artifacts::EXPOSE_AS_ERROR_MESSAGE
end
end
context "when 'expose_as' is used without 'paths'" do
let(:config) { { expose_as: 'Test results' } }
it 'reports error' do
expect(entry.errors)
.to include "artifacts paths can't be blank"
end
end
context "when 'paths' includes '*' and 'expose_as' is defined" do
let(:config) { { expose_as: 'Test results', paths: ['test.txt', 'test*.txt'] } }
it 'reports error' do
expect(entry.errors)
.to include "artifacts paths can't contain '*' when used with 'expose_as'"
end
end
end
end
context 'when the `when` keyword is not a string' do
context 'when it is an array' do
let(:config) { { paths: %w[results.txt], when: ['always'] } }
it 'returns error' do
expect(entry).not_to be_valid
expect(entry.errors).to include 'artifacts when should be a string'
end
end
context 'when it is a boolean' do
let(:config) { { paths: %w[results.txt], when: true } }
it 'returns error' do
expect(entry).not_to be_valid
expect(entry.errors).to include 'artifacts when should be a string'
end
end
end
describe 'excluded artifacts' do
context 'when configuration is valid' do
let(:config) { { untracked: true, exclude: ['some/directory/'] } }
it 'correctly parses the configuration' do
expect(entry).to be_valid
expect(entry.value).to eq config
end
end
context 'when configuration is not valid' do
let(:config) { { untracked: true, exclude: 1234 } }
it 'returns an error' do
expect(entry).not_to be_valid
expect(entry.errors)
.to include 'artifacts exclude should be an array of strings'
end
end
end
end
end
|